[jira] [Commented] (IVY-1561) Use Ivy properties to override Maven POM settings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IVY-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047449#comment-16047449 ] 

ASF GitHub Bot commented on IVY-1561:
-------------------------------------

GitHub user jaikiran opened a pull request:

    https://github.com/apache/ant-ivy/pull/44

    IVY-1561 - Enhancement to take into account environment and system properties while evaluation Maven pom property references

    The commit in this PR introduces the enhancement requested in https://issues.apache.org/jira/browse/IVY-1561 and includes a test case to verify it.
    
    Maven allows developers to refer to system properties and environment variables in the pom.xml file and those properties (of the form `${property}`) are evaluated by Maven by taking into account any environment variables or system properties set during that run. 
    
    Ivy, while creating a module descriptor out of pom.xml, didn't so far have this ability to account for environment variables and system properties while evaluating pom properties. The commit here introduces that ability.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/ant-ivy ivy-1561

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant-ivy/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #44
    
----
commit c07d659cf8f7b16452472da6052a1de326bcb6a4
Author: Jaikiran Pai <ja...@gmail.com>
Date:   2017-06-13T05:27:53Z

    IVY-1561 Take into account environment variable and system properties while evaluating property references in Maven pom.xml

----


> Use Ivy properties to override Maven POM settings
> -------------------------------------------------
>
>                 Key: IVY-1561
>                 URL: https://issues.apache.org/jira/browse/IVY-1561
>             Project: Ivy
>          Issue Type: Improvement
>          Components: Maven Compatibility
>    Affects Versions: 2.4.0
>            Reporter: Greg Hall
>            Priority: Minor
>
> I want to use Spring boot and Thymeleaf 3 with Ant+Ivy. Spring boot
> 1.5.3 (current release) by default loads older thymeleaf 2. Apparently, the
> solution in a Maven POM is to specify the following properties:
> <properties>
> 	<main.basedir>${basedir}/../..</main.basedir>
> 	<thymeleaf.version>3.0.2.RELEASE</thymeleaf.version>
> 	<thymeleaf-layout-dialect.version>2.1.1</thymeleaf-layout-dialect.version>
> </properties>
> See the external issue URL for reference where I found the Maven POM solution.
> I tried setting these as Ant properties before getting Ivy running, it makes no difference. I can use overrides in my dependencies to bring in version 3, but then it doesn't work, the code in spring boot seems to be expecting version 2.
> I'm not sure how those Maven properties actually get used when pulling
> in dependencies, but it seems Ivy currently lacks this feature.
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)