You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gabor Apati-Nagy <ga...@citrix.com> on 2014/08/25 22:42:02 UTC
Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25029/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle and Jessica Wang.
Repository: cloudstack-git
Description
-------
Replaced jquery.js file.
Diffs
-----
ui/lib/jquery.js 5d5a1d58ee5148d010b2029c419356440e679941
Diff: https://reviews.apache.org/r/25029/diff/
Testing
-------
I have done smoke test on the UI.
Thanks,
Gabor Apati-Nagy
Re: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4
Posted by David Nalley <da...@gnsa.us>.
Thanks Brian!
--David
On Tue, Aug 26, 2014 at 4:15 PM, Brian Federle <Br...@citrix.com> wrote:
> Hi David, I just updated NOTICE. I verified that the content in LICENSE is still the same from the prior version.
>
> -Brian
>
> 182a0786bdab96b2bc582bce7b8e0fee685d8fd4 HEAD asf/master master
> Author: Brian Federle <br...@citrix.com>
> Date: Tue Aug 26 13:13:29 2014 -0700
>
> Update NOTICE to account for updated jQuery version
>
> 1 file changed, 2 insertions(+), 2 deletions(-)
> NOTICE | 4 ++--
>
> Modified NOTICE
> diff --git a/NOTICE b/NOTICE
> index a74c0dc..b19e4a4 100644
> --- a/NOTICE
> +++ b/NOTICE
> @@ -29,7 +29,7 @@ Copyright 2014 The Apache Software Foundation
> jquery.js
>
>
> - jQuery JavaScript Library v1.6.1
> + jQuery JavaScript Library v1.6.4
> http://jquery.com/
>
> Copyright 2011, John Resig
> @@ -41,7 +41,7 @@ Copyright 2014 The Apache Software Foundation
> Copyright 2011, The Dojo Foundation
> Released under the MIT, BSD, and GPL Licenses.
>
> - Date: Thu May 12 15:04:36 2011 -0400
> + Date: Mon Sep 12 18:54:48 2011 -0400
>
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Tuesday, August 26, 2014 1:05 PM
> To: dev@cloudstack.apache.org; Gabor Apati-Nagy
> Cc: Jessica Wang; Brian Federle
> Subject: Re: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4
>
> This has implications for LICENSE and NOTICE. Please ensure they get updated as well.
>
> --David
>
> On Mon, Aug 25, 2014 at 4:42 PM, Gabor Apati-Nagy <ga...@citrix.com> wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/25029/
>> -----------------------------------------------------------
>>
>> Review request for cloudstack, Brian Federle and Jessica Wang.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Replaced jquery.js file.
>>
>>
>> Diffs
>> -----
>>
>> ui/lib/jquery.js 5d5a1d58ee5148d010b2029c419356440e679941
>>
>> Diff: https://reviews.apache.org/r/25029/diff/
>>
>>
>> Testing
>> -------
>>
>> I have done smoke test on the UI.
>>
>>
>> Thanks,
>>
>> Gabor Apati-Nagy
>>
RE: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to
1.6.4
Posted by Brian Federle <Br...@citrix.com>.
Hi David, I just updated NOTICE. I verified that the content in LICENSE is still the same from the prior version.
-Brian
182a0786bdab96b2bc582bce7b8e0fee685d8fd4 HEAD asf/master master
Author: Brian Federle <br...@citrix.com>
Date: Tue Aug 26 13:13:29 2014 -0700
Update NOTICE to account for updated jQuery version
1 file changed, 2 insertions(+), 2 deletions(-)
NOTICE | 4 ++--
Modified NOTICE
diff --git a/NOTICE b/NOTICE
index a74c0dc..b19e4a4 100644
--- a/NOTICE
+++ b/NOTICE
@@ -29,7 +29,7 @@ Copyright 2014 The Apache Software Foundation
jquery.js
- jQuery JavaScript Library v1.6.1
+ jQuery JavaScript Library v1.6.4
http://jquery.com/
Copyright 2011, John Resig
@@ -41,7 +41,7 @@ Copyright 2014 The Apache Software Foundation
Copyright 2011, The Dojo Foundation
Released under the MIT, BSD, and GPL Licenses.
- Date: Thu May 12 15:04:36 2011 -0400
+ Date: Mon Sep 12 18:54:48 2011 -0400
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Tuesday, August 26, 2014 1:05 PM
To: dev@cloudstack.apache.org; Gabor Apati-Nagy
Cc: Jessica Wang; Brian Federle
Subject: Re: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4
This has implications for LICENSE and NOTICE. Please ensure they get updated as well.
--David
On Mon, Aug 25, 2014 at 4:42 PM, Gabor Apati-Nagy <ga...@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25029/
> -----------------------------------------------------------
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Replaced jquery.js file.
>
>
> Diffs
> -----
>
> ui/lib/jquery.js 5d5a1d58ee5148d010b2029c419356440e679941
>
> Diff: https://reviews.apache.org/r/25029/diff/
>
>
> Testing
> -------
>
> I have done smoke test on the UI.
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
Re: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4
Posted by David Nalley <da...@gnsa.us>.
This has implications for LICENSE and NOTICE. Please ensure they get
updated as well.
--David
On Mon, Aug 25, 2014 at 4:42 PM, Gabor Apati-Nagy
<ga...@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25029/
> -----------------------------------------------------------
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Replaced jquery.js file.
>
>
> Diffs
> -----
>
> ui/lib/jquery.js 5d5a1d58ee5148d010b2029c419356440e679941
>
> Diff: https://reviews.apache.org/r/25029/diff/
>
>
> Testing
> -------
>
> I have done smoke test on the UI.
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
Re: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to
1.6.4
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25029/#review51576
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Aug. 25, 2014, 8:42 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25029/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 8:42 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Replaced jquery.js file.
>
>
> Diffs
> -----
>
> ui/lib/jquery.js 5d5a1d58ee5148d010b2029c419356440e679941
>
> Diff: https://reviews.apache.org/r/25029/diff/
>
>
> Testing
> -------
>
> I have done smoke test on the UI.
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>