You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/08 23:49:48 UTC
[GitHub] [commons-csv] SethFalco opened a new pull request #160: chore: update gitignore and add editorconfig
SethFalco opened a new pull request #160:
URL: https://github.com/apache/commons-csv/pull/160
I'm about to rebase and respond to your feedback on https://github.com/apache/commons-csv/pull/114.
Just wanted to propose some minor changes, though.
### .gitignore
* Ignores all IntelliJ specific files. (What I was using before, so had some files left around still.)
* Ignores all Visual Studio Code specific files. (What I'm using now.)
* Replaces the dead link at the top of the file.
### .editorconfig
For those using code editors like Visual Studio Code, it can be easier if the project defines its preferences using [EditorConfig](https://editorconfig.org/) to override any program settings. (a vendor-agnostic configuration file that many code editors support)
I've just taken the EditorConfig configuration from the most starred Java project Apache has on GitHub:
https://github.com/apache/dubbo/blob/3.0/.editorconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls edited a comment on pull request #160: chore: update gitignore to ignore idea and vscode
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #160:
URL: https://github.com/apache/commons-csv/pull/160#issuecomment-876845572
[](https://coveralls.io/builds/41235502)
Coverage remained the same at 98.31% when pulling **4f442ba0b26dbc8d7b123768c8e7c3c7a423c9cb on SethFalco:chores** into **46bae4b99b3151e7bb358a5fcb896be44324282d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] SethFalco edited a comment on pull request #160: chore: update gitignore to ignore idea and vscode
Posted by GitBox <gi...@apache.org>.
SethFalco edited a comment on pull request #160:
URL: https://github.com/apache/commons-csv/pull/160#issuecomment-876865502
Just made one more minor edit, sorry!
About to look at my PRs to commons-beanutils again since I left those hanging. ^-^'
Realized the IntelliJ/Eclipse files can be in submodule directories as well. Thought I should update that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #160: Update gitignore to ignore idea and vscode
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #160:
URL: https://github.com/apache/commons-csv/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls commented on pull request #160: chore: update gitignore and add editorconfig
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #160:
URL: https://github.com/apache/commons-csv/pull/160#issuecomment-876845572
[](https://coveralls.io/builds/41233403)
Coverage remained the same at 98.31% when pulling **08b373df9f9bf2a6d9f012a7c38dc7664d6ea6f5 on SethFalco:chores** into **ca5eb7cdbe1a80186fdade49dbe9062d87540c8e on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #160: chore: update gitignore and add editorconfig
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #160:
URL: https://github.com/apache/commons-csv/pull/160#issuecomment-876848687
We don't use editorconfig anywhere in Commons that I'm aware of so let's skip it. If anything , we could store formatting configs for Eclipse, IJ, and so on in src/conf, maybe...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] SethFalco commented on pull request #160: chore: update gitignore to ignore idea and vscode
Posted by GitBox <gi...@apache.org>.
SethFalco commented on pull request #160:
URL: https://github.com/apache/commons-csv/pull/160#issuecomment-876865502
Just made one more minor edit, sorry!
About to look at my PRs to commons-beanutils again since I left those hanging. ^-^'
Realized `.settings` can be in, submodule directories as well. Thought I should update that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org