[jira] [Commented] (WHIRR-440) Unit tests improvements (less bound to external services)

["Tom White (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIRR-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164145#comment-13164145 ] 

Tom White commented on WHIRR-440:
---------------------------------

+1

There's a checkstyle warning in FastDnsResolver. After I fixed that all the unit tests passed for me.

Also, how about changing o.a.whirr.service.state to o.a.whirr.state, and o.a.whirr.util.dns to o.a.whirr.net?
                
> Unit tests improvements (less bound to external services)
> ---------------------------------------------------------
>
>                 Key: WHIRR-440
>                 URL: https://issues.apache.org/jira/browse/WHIRR-440
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.7.0
>
>         Attachments: WHIRR-440.patch
>
>
> In this patch I have made the unit tests less dependent on having the ability to perform reverse DNS 
> resolution and I have also switched some tests to use a memory based state store. We should set a 
> goal for 0.8.0 to be able to run the unit tests without having an internet connection. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira