You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/09 17:02:50 UTC

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6431: Address issue #6415 using compiler-rt half-float function.

tqchen commented on a change in pull request #6431:
URL: https://github.com/apache/incubator-tvm/pull/6431#discussion_r485779432



##########
File path: src/relay/transforms/pattern_util.h
##########
@@ -398,7 +398,8 @@ static inline long double ToScalar(const runtime::NDArray& array, size_t i = 0)
   } else if (array->dtype.code == kDLFloat) {
 #if (__ARM_FP16_FORMAT_IEEE == 1)

Review comment:
       perhaps we no longer need this macro guard anymore




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org