You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/10 15:55:17 UTC
[GitHub] [camel] Croway opened a new pull request #6522: [CAMEL-17310] Add dev goal to enable live reloading
Croway opened a new pull request #6522:
URL: https://github.com/apache/camel/pull/6522
As discussed in https://issues.apache.org/jira/browse/CAMEL-17310 there are some issues with live reload, I'll try to investigate more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on pull request #6522: [CAMEL-17310] Add dev goal to enable live reloading
Posted by GitBox <gi...@apache.org>.
Croway commented on pull request #6522:
URL: https://github.com/apache/camel/pull/6522#issuecomment-991757137
> The fileWatcherDirectory was the old name, we can give it a better and shorter name.
>
> Also I think the plugin should default to reload automatic, and automatic select the src/main/resources directory. There is a way via a maven plugin to get hold of "resource directory" but I guess that 99% its always src/main/resources anyway.
>
> For java routes then its a bit more tricky as they would be in src/main/java. So we can in the future have some kind of watcher that automatic detects all .java source files and whether they are Camel routes.
Thanks, I have implemented your comment, moreover I had to do some changes to RouteWatcherReloadStrategy in order to handle recursive live reload, and I did some changes in case of file removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #6522: [CAMEL-17310] Add dev goal to enable live reloading
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #6522:
URL: https://github.com/apache/camel/pull/6522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6522: [CAMEL-17310] Add dev goal to enable live reloading
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6522:
URL: https://github.com/apache/camel/pull/6522#issuecomment-991215914
The fileWatcherDirectory was the old name, we can give it a better and shorter name.
Also I think the plugin should default to reload automatic, and automatic select the src/main/resources directory.
There is a way via a maven plugin to get hold of "resource directory" but I guess that 99% its always src/main/resources anyway.
For java routes then its a bit more tricky as they would be in src/main/java. So we can in the future have some kind of watcher that automatic detects all .java source files and whether they are Camel routes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6522: [CAMEL-17310] Add dev goal to enable live reloading
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6522:
URL: https://github.com/apache/camel/pull/6522#issuecomment-991215914
The fileWatcherDirectory was the old name, we can give it a better and shorter name.
Also I think the plugin should default to reload automatic, and automatic select the src/main/resources directory.
There is a way via a maven plugin to get hold of "resource directory" but I guess that 99% its always src/main/resources anyway.
For java routes then its a bit more tricky as they would be in src/main/java. So we can in the future have some kind of watcher that automatic detects all .java source files and whether they are Camel routes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway commented on pull request #6522: [CAMEL-17310] Add dev goal to enable live reloading
Posted by GitBox <gi...@apache.org>.
Croway commented on pull request #6522:
URL: https://github.com/apache/camel/pull/6522#issuecomment-991757137
> The fileWatcherDirectory was the old name, we can give it a better and shorter name.
>
> Also I think the plugin should default to reload automatic, and automatic select the src/main/resources directory. There is a way via a maven plugin to get hold of "resource directory" but I guess that 99% its always src/main/resources anyway.
>
> For java routes then its a bit more tricky as they would be in src/main/java. So we can in the future have some kind of watcher that automatic detects all .java source files and whether they are Camel routes.
Thanks, I have implemented your comment, moreover I had to do some changes to RouteWatcherReloadStrategy in order to handle recursive live reload, and I did some changes in case of file removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org