[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11260: [Fix-11237][api&datasource-plugin]fix Presto data source bug

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #11260:
URL: https://github.com/apache/dolphinscheduler/pull/11260#discussion_r935400881


##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-presto/src/main/java/org/apache/dolphinscheduler/plugin/datasource/presto/param/PrestoDataSourceProcessor.java:
##########
@@ -59,7 +62,7 @@ public BaseDataSourceParamDTO createDatasourceParamDTO(String connectionJson) {
                 prestoDatasourceParamDTO = new PrestoDataSourceParamDTO();
         prestoDatasourceParamDTO.setPort(Integer.parseInt(hostPortArray[0].split(Constants.COLON)[1]));
         prestoDatasourceParamDTO.setHost(hostPortArray[0].split(Constants.COLON)[0]);
-        prestoDatasourceParamDTO.setDatabase(connectionParams.getDatabase());
+        prestoDatasourceParamDTO.setDatabase(connectionParams.getDatabase() + "/" + connectionParams.getSchema());

Review Comment:
   It's better to use `org.apache.dolphinscheduler.spi.utils.Constants#SLASH` to replace `/`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org