You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/30 06:28:51 UTC

[GitHub] [arrow-rs] sum12 commented on a change in pull request #1451: Allow json reader/decoder to work with format_strings for each field and use Parser trait correspondingly

sum12 commented on a change in pull request #1451:
URL: https://github.com/apache/arrow-rs/pull/1451#discussion_r838163495



##########
File path: arrow/src/json/reader.rs
##########
@@ -589,11 +592,13 @@ impl Decoder {
         schema: SchemaRef,
         batch_size: usize,
         projection: Option<Vec<String>>,
+        format_strings: Option<HashMap<String, String>>,

Review comment:
       I often wondered too. Wouldn't it allow the parser to diverge from schema ? We would need a runtime validation of what schema says and formaters actually return.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org