You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/16 07:37:44 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10468: [Improvement][Api] Interface and entity optimization to improve code scalability (#10466).

SbloodyS commented on code in PR #10468:
URL: https://github.com/apache/dolphinscheduler/pull/10468#discussion_r898787701


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -113,9 +126,10 @@ public Result createProcessDefinition(@ApiIgnore @RequestAttribute(value = Const
                                           @RequestParam(value = "tenantCode", required = true) String tenantCode,
                                           @RequestParam(value = "taskRelationJson", required = true) String taskRelationJson,
                                           @RequestParam(value = "taskDefinitionJson", required = true) String taskDefinitionJson,
+                                          @RequestParam(value = "otherParamsJson", required = false) String otherParamsJson,

Review Comment:
   We should add this param to the swagger's doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org