You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by il...@apache.org on 2019/08/19 08:42:26 UTC
[dubbo] branch master updated: Optimize StringBuilder#append (#4872)
This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new b5bfacc Optimize StringBuilder#append (#4872)
b5bfacc is described below
commit b5bfacc12847c76303833372f4fdf6242c348f31
Author: thelproad <54...@users.noreply.github.com>
AuthorDate: Mon Aug 19 16:42:13 2019 +0800
Optimize StringBuilder#append (#4872)
---
.../rpc/protocol/dubbo/status/ThreadPoolStatusChecker.java | 10 +++-------
.../dubbo/rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java | 6 +++---
.../dubbo/rpc/protocol/dubbo/telnet/CountTelnetHandler.java | 4 ++--
.../dubbo/rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java | 2 +-
.../dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java | 12 ++++++------
.../dubbo/rpc/protocol/dubbo/telnet/PortTelnetHandler.java | 6 +++---
6 files changed, 18 insertions(+), 22 deletions(-)
diff --git a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/status/ThreadPoolStatusChecker.java b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/status/ThreadPoolStatusChecker.java
index 8506f1b..a00eea6 100644
--- a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/status/ThreadPoolStatusChecker.java
+++ b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/status/ThreadPoolStatusChecker.java
@@ -56,13 +56,9 @@ public class ThreadPoolStatusChecker implements StatusChecker {
if (msg.length() > 0) {
msg.append(";");
}
- msg.append("Pool status:" + lvl
- + ", max:" + tp.getMaximumPoolSize()
- + ", core:" + tp.getCorePoolSize()
- + ", largest:" + tp.getLargestPoolSize()
- + ", active:" + tp.getActiveCount()
- + ", task:" + tp.getTaskCount()
- + ", service port: " + port);
+ msg.append("Pool status:").append(lvl).append(", max:").append(tp.getMaximumPoolSize()).append(", core:")
+ .append(tp.getCorePoolSize()).append(", largest:").append(tp.getLargestPoolSize()).append(", active:")
+ .append(tp.getActiveCount()).append(", task:").append(tp.getTaskCount()).append(", service port: ").append(port);
}
}
return msg.length() == 0 ? new Status(Status.Level.UNKNOWN) : new Status(level, msg.toString());
diff --git a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java
index 77d32ec..0b55fa9 100644
--- a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java
+++ b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java
@@ -41,7 +41,7 @@ public class ChangeTelnetHandler implements TelnetHandler {
if ("/".equals(message) || "..".equals(message)) {
String service = (String) channel.getAttribute(SERVICE_KEY);
channel.removeAttribute(SERVICE_KEY);
- buf.append("Cancelled default service " + service + ".");
+ buf.append("Cancelled default service ").append(service).append(".");
} else {
boolean found = false;
for (Exporter<?> exporter : DubboProtocol.getDubboProtocol().getExporters()) {
@@ -54,9 +54,9 @@ public class ChangeTelnetHandler implements TelnetHandler {
}
if (found) {
channel.setAttribute(SERVICE_KEY, message);
- buf.append("Used the " + message + " as default.\r\nYou can cancel default service by command: cd /");
+ buf.append("Used the ").append(message).append(" as default.\r\nYou can cancel default service by command: cd /");
} else {
- buf.append("No such service " + message);
+ buf.append("No such service ").append(message);
}
}
return buf.toString();
diff --git a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/CountTelnetHandler.java b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/CountTelnetHandler.java
index 81e4900..7deea41 100644
--- a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/CountTelnetHandler.java
+++ b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/CountTelnetHandler.java
@@ -49,7 +49,7 @@ public class CountTelnetHandler implements TelnetHandler {
}
StringBuilder buf = new StringBuilder();
if (service != null && service.length() > 0) {
- buf.append("Use default service " + service + ".\r\n");
+ buf.append("Use default service ").append(service).append(".\r\n");
}
String[] parts = message.split("\\s+");
String method;
@@ -112,7 +112,7 @@ public class CountTelnetHandler implements TelnetHandler {
thread.start();
}
} else {
- buf.append("No such service " + service);
+ buf.append("No such service ").append(service);
}
return buf.toString();
}
diff --git a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
index 3998026..1bb1ed9 100644
--- a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
+++ b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
@@ -237,7 +237,7 @@ public class InvokeTelnetHandler implements TelnetHandler {
buf.append("Methods:\r\n");
for (int i = 0; i < methods.size(); i++) {
Method method = methods.get(i);
- buf.append((i + 1) + ". " + method.getName() + "(");
+ buf.append(i + 1).append(". ").append(method.getName()).append("(");
Class<?>[] parameterTypes = method.getParameterTypes();
for (int n = 0; n < parameterTypes.length; n++) {
buf.append(parameterTypes[n].getSimpleName());
diff --git a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java
index 86bcd9b..f6c388d 100644
--- a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java
+++ b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java
@@ -70,11 +70,11 @@ public class LogTelnetHandler implements TelnetHandler {
bb.flip();
String content = new String(bb.array()).replace("<", "<")
.replace(">", ">").replace("\n", "<br/><br/>");
- buf.append("\r\ncontent:" + content);
+ buf.append("\r\ncontent:").append(content);
- buf.append("\r\nmodified:" + (new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
- .format(new Date(file.lastModified()))));
- buf.append("\r\nsize:" + size + "\r\n");
+ buf.append("\r\nmodified:").append(new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
+ .format(new Date(file.lastModified())));
+ buf.append("\r\nsize:").append(size).append("\r\n");
} catch (Exception e) {
buf.append(e.getMessage());
}
@@ -84,8 +84,8 @@ public class LogTelnetHandler implements TelnetHandler {
}
}
}
- buf.append("\r\nCURRENT LOG LEVEL:" + LoggerFactory.getLevel())
- .append("\r\nCURRENT LOG APPENDER:" + (file == null ? "console" : file.getAbsolutePath()));
+ buf.append("\r\nCURRENT LOG LEVEL:").append(LoggerFactory.getLevel()).append("\r\nCURRENT LOG APPENDER:")
+ .append(file == null ? "console" : file.getAbsolutePath());
return buf.toString();
}
diff --git a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/PortTelnetHandler.java b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/PortTelnetHandler.java
index 4965548..65a4732 100644
--- a/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/PortTelnetHandler.java
+++ b/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/telnet/PortTelnetHandler.java
@@ -58,7 +58,7 @@ public class PortTelnetHandler implements TelnetHandler {
buf.append("\r\n");
}
if (detail) {
- buf.append(server.getUrl().getProtocol() + "://" + server.getUrl().getAddress());
+ buf.append(server.getUrl().getProtocol()).append("://").append(server.getUrl().getAddress());
} else {
buf.append(server.getUrl().getPort());
}
@@ -79,13 +79,13 @@ public class PortTelnetHandler implements TelnetHandler {
buf.append("\r\n");
}
if (detail) {
- buf.append(c.getRemoteAddress() + " -> " + c.getLocalAddress());
+ buf.append(c.getRemoteAddress()).append(" -> ").append(c.getLocalAddress());
} else {
buf.append(c.getRemoteAddress());
}
}
} else {
- buf.append("No such port " + port);
+ buf.append("No such port ").append(port);
}
}
return buf.toString();