You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "youxiudeshouyeren (via GitHub)" <gi...@apache.org> on 2024/01/30 08:32:11 UTC
[I] [Bug] debug_get_output function of debug_executor reports error in parameter passing. [tvm]
youxiudeshouyeren opened a new issue, #16490:
URL: https://github.com/apache/tvm/issues/16490
In the debug_executor's `debug_get_output` function, the out parameter can be set to None, but in the C++ implementation of the function, there is no check to see if the out parameter is None, which can result in the program reporting an error without a prompt. The details are as follows:
1. `debug_get_output` function in tvm/python/tvm/contrib/debugger/debug_executor.py

2. C++ implementation in tvm/src/runtime/graph_executor/debug/graph_executor_debug.cc. This function has no return value and copies Ndarray directly to the out parameter in python.

3. When out is None, this will raise a direct error: segment fault

I would like to raise a pr to address this issue. Now there are two choices:
1. check at python level that this out parameter cannot be None.
2. check the number of arguments in C++ and return Ndarray directly when out is None. This operation has the same behavior as get_output function in executor.
I prefer the second choice. Thanks for reading and what do you suggest?
@Hzfengsy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] debug_get_output function of debug_executor reports error in parameter passing. [tvm]
Posted by "youxiudeshouyeren (via GitHub)" <gi...@apache.org>.
youxiudeshouyeren closed issue #16490: [Bug] debug_get_output function of debug_executor reports error in parameter passing.
URL: https://github.com/apache/tvm/issues/16490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] debug_get_output function of debug_executor reports error in parameter passing. [tvm]
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on issue #16490:
URL: https://github.com/apache/tvm/issues/16490#issuecomment-1916428616
The second one looks good to me. Could you send a PR to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] debug_get_output function of debug_executor reports error in parameter passing. [tvm]
Posted by "youxiudeshouyeren (via GitHub)" <gi...@apache.org>.
youxiudeshouyeren commented on issue #16490:
URL: https://github.com/apache/tvm/issues/16490#issuecomment-1958809523
This bug has been fixed in #16492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org