You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2018/05/14 19:09:15 UTC
[incubator-superset] branch master updated: cleaning up the table
fab view since we hide these autogenerated metrics anyway (#4992)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new ce710f8 cleaning up the table fab view since we hide these autogenerated metrics anyway (#4992)
ce710f8 is described below
commit ce710f8c8ff3feaef307e4b0f2f1a7560b7f95d5
Author: Gabe Lyons <ga...@airbnb.com>
AuthorDate: Mon May 14 12:09:12 2018 -0700
cleaning up the table fab view since we hide these autogenerated metrics anyway (#4992)
---
superset/connectors/sqla/views.py | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py
index f0f5afb..b73a29c 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -37,12 +37,12 @@ class TableColumnInlineView(CompactCRUDMixin, SupersetModelView): # noqa
edit_columns = [
'column_name', 'verbose_name', 'description',
'type', 'groupby', 'filterable',
- 'table', 'count_distinct', 'sum', 'min', 'max', 'expression',
+ 'table', 'expression',
'is_dttm', 'python_date_format', 'database_expression']
add_columns = edit_columns
list_columns = [
- 'column_name', 'verbose_name', 'type', 'groupby', 'filterable', 'count_distinct',
- 'sum', 'min', 'max', 'is_dttm']
+ 'column_name', 'verbose_name', 'type', 'groupby', 'filterable',
+ 'is_dttm']
page_size = 500
description_columns = {
'is_dttm': _(
@@ -86,10 +86,6 @@ class TableColumnInlineView(CompactCRUDMixin, SupersetModelView): # noqa
'groupby': _('Groupable'),
'filterable': _('Filterable'),
'table': _('Table'),
- 'count_distinct': _('Count Distinct'),
- 'sum': _('Sum'),
- 'min': _('Min'),
- 'max': _('Max'),
'expression': _('Expression'),
'is_dttm': _('Is temporal'),
'python_date_format': _('Datetime Format'),
--
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.