You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/09/11 20:06:01 UTC
[kudu-CR] [master] fix compilation warning of DCHECK NOTNULL
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11421
Change subject: [master] fix compilation warning of DCHECK_NOTNULL
......................................................................
[master] fix compilation warning of DCHECK_NOTNULL
Fixed compilation warning in case of RELEASE build:
kudu/master/ts_descriptor.cc:103:18: warning:
expression result unused [-Wunused-value]
DCHECK_NOTNULL(location);
^~~~~~~~
This patch does not contain any functional changes.
This is a follow-up to dcc39d53d8c36a3f4896ce4c208b855abee8da83.
Change-Id: I768afd0ec34f8127f66ea33338ca29ec337488c5
---
M src/kudu/master/ts_descriptor.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/11421/1
--
To view, visit http://gerrit.cloudera.org:8080/11421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I768afd0ec34f8127f66ea33338ca29ec337488c5
Gerrit-Change-Number: 11421
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master] fix compilation warning of DCHECK NOTNULL
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11421 )
Change subject: [master] fix compilation warning of DCHECK_NOTNULL
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I768afd0ec34f8127f66ea33338ca29ec337488c5
Gerrit-Change-Number: 11421
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 20:20:44 +0000
Gerrit-HasComments: No
[kudu-CR] [master] fix compilation warning of DCHECK NOTNULL
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11421 )
Change subject: [master] fix compilation warning of DCHECK_NOTNULL
......................................................................
[master] fix compilation warning of DCHECK_NOTNULL
Fixed compilation warning in case of RELEASE build:
kudu/master/ts_descriptor.cc:103:18: warning:
expression result unused [-Wunused-value]
DCHECK_NOTNULL(location);
^~~~~~~~
This patch does not contain any functional changes.
This is a follow-up to dcc39d53d8c36a3f4896ce4c208b855abee8da83.
Change-Id: I768afd0ec34f8127f66ea33338ca29ec337488c5
Reviewed-on: http://gerrit.cloudera.org:8080/11421
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/ts_descriptor.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I768afd0ec34f8127f66ea33338ca29ec337488c5
Gerrit-Change-Number: 11421
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>