[jira] [Commented] (HBASE-14467) Compaction improvements: DefaultCompactor should not compact TTL-expired files

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907478#comment-14907478 ] 

Hadoop QA commented on HBASE-14467:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12762286/HBASE-14467-v1.patch
  against master branch at commit 8db7a6eb079018e3f94cc366ef85211d7a90f749.
  ATTACHMENT ID: 12762286

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1785 checkstyle errors (more than the master's current 1783 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestColumnSeeking
                  org.apache.hadoop.hbase.regionserver.TestMinVersions
                  org.apache.hadoop.hbase.regionserver.TestKeepDeletes

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15731//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15731//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15731//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15731//console

This message is automatically generated.

> Compaction improvements: DefaultCompactor should not compact TTL-expired files
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-14467
>                 URL: https://issues.apache.org/jira/browse/HBASE-14467
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14467-v1.patch
>
>
> DefaultCompactor does not check if store file can be completely purged because of TTL expiration. That is simple optimization which allows to implement such "exotic"compaction policy as FIFO compaction (https://github.com/facebook/rocksdb/wiki/FIFO-compaction-style). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)