You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/24 22:18:34 UTC

[GitHub] [incubator-gobblin] zxcware opened a new pull request #2937: [GOBBLIN-1096] Work with DST change in compaction watermark

zxcware opened a new pull request #2937: [GOBBLIN-1096] Work with DST change in compaction watermark
URL: https://github.com/apache/incubator-gobblin/pull/2937
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. 
       - https://issues.apache.org/jira/browse/GOBBLIN-1096
   
   
   ### Description
   - [x] Here are some details about my PR:
     - Increment existing compaction watermark by 1 day with DST in mind. Luckily, since 1.8, java time handles DST in PST time zone
   
   ### Tests
   - [x] My PR adds the following unit tests:
     - `CompactionWatermarkActionTest.testWatermarkWithDST` verified that DST change on 03/08/2020 was handled correctly in PST timezone
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] asfgit closed pull request #2937: [GOBBLIN-1096] Work with DST change in compaction watermark

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2937: [GOBBLIN-1096] Work with DST change in compaction watermark
URL: https://github.com/apache/incubator-gobblin/pull/2937
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2937: [GOBBLIN-1096] Work with DST change in compaction watermark

Posted by GitBox <gi...@apache.org>.
jhsenjaliya commented on issue #2937: [GOBBLIN-1096] Work with DST change in compaction watermark
URL: https://github.com/apache/incubator-gobblin/pull/2937#issuecomment-603659833
 
 
   +1 LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services