You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/12 17:05:21 UTC

[GitHub] [pinot] chenboat commented on a change in pull request #7559: Make dim tables creation bypass tenant validation

chenboat commented on a change in pull request #7559:
URL: https://github.com/apache/pinot/pull/7559#discussion_r727334576



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1294,7 +1294,7 @@ void validateTableTenantConfig(TableConfig tableConfig) {
       tagsToCheck.add(completedServerTag);
     }
     for (String tag : tagsToCheck) {
-      if (getInstancesWithTag(tag).isEmpty()) {
+      if (!tableConfig.isDimTable() && getInstancesWithTag(tag).isEmpty()) {

Review comment:
       Please double check and add unit tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org