You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/16 13:01:05 UTC

[jira] [Commented] (METRON-230) BasicBroParser returns null if a message is not parseable. It should throw an exception.

    [ https://issues.apache.org/jira/browse/METRON-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333720#comment-15333720 ] 

ASF GitHub Bot commented on METRON-230:
---------------------------------------

GitHub user cestella opened a pull request:

    https://github.com/apache/incubator-metron/pull/154

    METRON-230: Bro parser should throw exception

    Right now, if an invalid message comes to the bro parser, it returns null, which is interpreted as no messages from the parser.  INstead, we should throw an exception so the message can be routed to the error queue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron METRON-230

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 5c507f682f60d3ddf333d31f1401d907778ec6e3
Author: cstella <ce...@gmail.com>
Date:   2016-06-16T12:59:06Z

    METRON-230: Bro parser should throw exception rather than returning null.

----


> BasicBroParser returns null if a message is not parseable.  It should throw an exception.
> -----------------------------------------------------------------------------------------
>
>                 Key: METRON-230
>                 URL: https://issues.apache.org/jira/browse/METRON-230
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Casey Stella
>              Labels: easyfix
>
> The basic bro parser is returning null in the situation where a message is not able to be parsed.  We should throw an exception so that the message is routed to the error queue for debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)