You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/06/26 18:05:36 UTC
(datafusion) branch gh-readonly-queue/main/pr-23200-bde8e5b24e772210885ea5272e5cb06b52c939c3 created (now d111dd037e)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-23200-bde8e5b24e772210885ea5272e5cb06b52c939c3
in repository https://gitbox.apache.org/repos/asf/datafusion.git
at d111dd037e doc: More comments on GroupedHashAggregateStream refactor (#23200)
This branch includes the following new commits:
new d111dd037e doc: More comments on GroupedHashAggregateStream refactor (#23200)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org
(datafusion) 01/01: doc: More comments on GroupedHashAggregateStream refactor (#23200)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-23200-bde8e5b24e772210885ea5272e5cb06b52c939c3
in repository https://gitbox.apache.org/repos/asf/datafusion.git
commit d111dd037e738318fa7e1a86851e54af09b7ad6a
Author: Yongting You <20...@gmail.com>
AuthorDate: Sat Jun 27 02:05:16 2026 +0800
doc: More comments on GroupedHashAggregateStream refactor (#23200)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
Original discussion: https://github.com/apache/datafusion/pull/23165
This PR adds more comments to explain the on-going refactor, to reduce
confusion.
- refactor: https://github.com/apache/datafusion/issues/22710
cc @alamb @Rachelint
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
---
datafusion/physical-plan/src/aggregates/mod.rs | 9 ++++++++-
datafusion/physical-plan/src/aggregates/row_hash.rs | 10 ++++++++++
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/datafusion/physical-plan/src/aggregates/mod.rs b/datafusion/physical-plan/src/aggregates/mod.rs
index 08468bffc0..4f5b893578 100644
--- a/datafusion/physical-plan/src/aggregates/mod.rs
+++ b/datafusion/physical-plan/src/aggregates/mod.rs
@@ -1009,6 +1009,13 @@ impl AggregateExec {
));
}
+ // `GroupedHashAggregateStream` is being incrementally refactored. See the
+ // tracking issue for details.
+ //
+ // New features and improvements should go directly into the new implementation.
+ // Please coordinate through the tracking issue.
+ //
+ // Issue: <https://github.com/apache/datafusion/issues/22710>
if context
.session_config()
.options()
@@ -1028,7 +1035,7 @@ impl AggregateExec {
}
}
- // grouping by something else and we need to just materialize all results
+ // Execution paths that have not been migrated use the fallback implementation
Ok(StreamType::GroupedHash(GroupedHashAggregateStream::new(
self, context, partition,
)?))
diff --git a/datafusion/physical-plan/src/aggregates/row_hash.rs b/datafusion/physical-plan/src/aggregates/row_hash.rs
index 5cd7f508af..a4d19b0f7d 100644
--- a/datafusion/physical-plan/src/aggregates/row_hash.rs
+++ b/datafusion/physical-plan/src/aggregates/row_hash.rs
@@ -132,6 +132,16 @@ enum OutOfMemoryMode {
/// HashTable based Grouping Aggregator
///
+/// # Development Note
+///
+/// This implementation is being incrementally refactored. See the tracking issue
+/// for details.
+///
+/// New features and improvements should go directly into the new implementation.
+/// Please coordinate through the tracking issue.
+///
+/// Issue: <https://github.com/apache/datafusion/issues/22710>
+///
/// # Design Goals
///
/// This structure is designed so that updating the aggregates can be
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org