You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by vraghavan78 <gi...@git.apache.org> on 2016/05/18 04:03:28 UTC

[GitHub] incubator-hawq pull request: Deadcode #119780063

GitHub user vraghavan78 opened a pull request:

    https://github.com/apache/incubator-hawq/pull/661

    Deadcode #119780063

    Context: When we did not have optimization modules in Orca and just DXL, we used CTranslatorDXLToQuery to test correctness of translation of Query to DXL.
    
    @changleicn @liming01 please review and merge this PR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vraghavan78/incubator-hawq deadcode-#119780063

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #661
    
----
commit 54f92aecb93720055a136596c961fb2552c98751
Author: Venkatesh (Venky) Raghavan <vr...@pivotal.io>
Date:   2016-05-18T03:58:48Z

    Delete Deadcode: CTranslatorDXLToQuery [#119780063]

commit e6ff60e835c782ed8bb02cab0de03b384514fe25
Author: Venkatesh (Venky) Raghavan <vr...@pivotal.io>
Date:   2016-05-18T04:02:57Z

    Delete Deadcode: CTranslatorDXLToQuery [#119780063]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #661: Deadcode #119780063

Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the issue:

    https://github.com/apache/incubator-hawq/pull/661
  
    @vraghavan78 , your PR#661 can't build successfully. Please fix it and then I'll merge it. Also help to check related PR#644 and PR#646. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: Deadcode #119780063

Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/661#issuecomment-222340720
  
    Apache HAWQ JIRA issue was created for this PR:
    https://issues.apache.org/jira/browse/HAWQ-765


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #661: Deadcode #119780063

Posted by vraghavan78 <gi...@git.apache.org>.
Github user vraghavan78 commented on the issue:

    https://github.com/apache/incubator-hawq/pull/661
  
    I rebased from master and it compiles.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #661: Deadcode #119780063

Posted by vraghavan78 <gi...@git.apache.org>.
Github user vraghavan78 closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/661


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---