[GitHub] [commons-lang] namannigam commented on a change in pull request #510: [LANG-1535] Add containsAnyIgnoreCase() method to StringUtils.

[GitBox <gi...@apache.org>]

namannigam commented on a change in pull request #510: [LANG-1535] Add containsAnyIgnoreCase() method to StringUtils.
URL: https://github.com/apache/commons-lang/pull/510#discussion_r410686757
 
 

 ##########
 File path: src/test/java/org/apache/commons/lang3/StringUtilsContainsTest.java
 ##########
 @@ -292,6 +292,28 @@ public void testContainsIgnoreCase_StringString() {
         assertTrue(StringUtils.containsIgnoreCase("xabcz", "ABC"));
     }
 
+    @Test
+    public void testContainsAnyIgnoreCase_StringStringArray() {
+        assertFalse(StringUtils.containsAnyIgnoreCase(null, (String[]) null));
+        assertFalse(StringUtils.containsAnyIgnoreCase(null, new String[0]));
+        assertFalse(StringUtils.containsAnyIgnoreCase(null, new String[] { "hello" }));
 
 Review comment:
   these would precisely short-circuit at the same condition as with the assertion before these and hence might just be redundant

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services