You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/22 04:40:59 UTC

[GitHub] [bookkeeper] Shoothzj commented on a diff in pull request #3285: validate diskUsageThreshold and diskUsageLwmThreshold

Shoothzj commented on code in PR #3285:
URL: https://github.com/apache/bookkeeper/pull/3285#discussion_r927283344


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java:
##########
@@ -229,5 +231,18 @@ private void checkDirs(final LedgerDirsManager ldm)
         }
         ldm.getWritableLedgerDirs();
     }
+
+    @VisibleForTesting
+    void setDiskSpaceThreshold(float diskSpaceThreshold, float diskUsageLwmThreshold) {

Review Comment:
   do we really need this method? can we instantiate a LedgerDirsMonitor to run tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org