[GitHub] access2rohit commented on a change in pull request #12594: [MXNET-867] Pooling1D with "same" padding

[GitBox <gi...@apache.org>]

access2rohit commented on a change in pull request #12594: [MXNET-867] Pooling1D with "same" padding
URL: https://github.com/apache/incubator-mxnet/pull/12594#discussion_r218990677
 
 

 ##########
 File path: src/operator/nn/pooling.cc
 ##########
 @@ -126,8 +126,8 @@ static bool PoolingShape(const nnvm::NodeAttrs &attrs,
       oshape[2] = 1 +
                   (dshape[2] + 2 * param.pad[0] - param.kernel[0]) /
                       param.stride[0];
-    } else {
-      oshape[2] = 1 + static_cast<int>(std::ceil(
+    } else if (param.pooling_convention == pool_enum::kFull) {
 
 Review comment:
   You introduced "else if" and removed "else". So there is no default behavior here. Are you sure all the cases will fall under these 2 conditionals only ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services