You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/01 06:27:23 UTC
[GitHub] [spark] sarutak opened a new pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
sarutak opened a new pull request #31412:
URL: https://github.com/apache/spark/pull/31412
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Similar to SPARK-33690, this PR improves the output layout of `printSchema` for the case column names contain meta characters.
Here is an example.
Before:
```
scala> val df1 = spark.sql("SELECT 'aaa\nbbb\tccc\rddd\feee\bfff\u000Bggg\u0007hhh'")
scala> df1.printSchema
root
|-- aaa
ddd ccc
eefff
ggghhh: string (nullable = false)
```
After:
```
scala> df1.printSchema
root
|-- aaa\nbbb\tccc\rddd\feee\bfff\vggg\ahhh: string (nullable = false)
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To avoid breaking the layout of `Dataset#printSchema`
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770799655
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134713/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770798550
**[Test build #134713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134713/testReport)** for PR 31412 at commit [`bbab015`](https://github.com/apache/spark/commit/bbab0156997975e5af90db4079a7c99b383b5b6a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770799655
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134713/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770622181
**[Test build #134713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134713/testReport)** for PR 31412 at commit [`bbab015`](https://github.com/apache/spark/commit/bbab0156997975e5af90db4079a7c99b383b5b6a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31412:
URL: https://github.com/apache/spark/pull/31412#discussion_r567840793
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala
##########
@@ -271,4 +271,18 @@ private[spark] object SchemaUtils {
}
field._1
}
+
+ /**
+ * @param str The string to be escaped.
+ * @return The escaped string.
+ */
+ def escapeMetaCharacters(str: String): String = {
Review comment:
Hmm, I intended to use this for escaping strings in schema so I implemented this in `SchemaUtils`.
In fact, it's used for such purpose for now.
If we find it's useful for other purposes, how about moving this into a different place in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770622181
**[Test build #134713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134713/testReport)** for PR 31412 at commit [`bbab015`](https://github.com/apache/spark/commit/bbab0156997975e5af90db4079a7c99b383b5b6a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770637957
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39299/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770654078
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39299/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770654052
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39299/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-772154620
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31412:
URL: https://github.com/apache/spark/pull/31412#issuecomment-770654078
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39299/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31412:
URL: https://github.com/apache/spark/pull/31412#discussion_r567866595
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala
##########
@@ -271,4 +271,18 @@ private[spark] object SchemaUtils {
}
field._1
}
+
+ /**
+ * @param str The string to be escaped.
+ * @return The escaped string.
+ */
+ def escapeMetaCharacters(str: String): String = {
Review comment:
sgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31412:
URL: https://github.com/apache/spark/pull/31412#discussion_r567767319
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala
##########
@@ -271,4 +271,18 @@ private[spark] object SchemaUtils {
}
field._1
}
+
+ /**
+ * @param str The string to be escaped.
+ * @return The escaped string.
+ */
+ def escapeMetaCharacters(str: String): String = {
Review comment:
How about moving this into `org.apache.spark.sql.catalyst.util.StringUtils` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31412:
URL: https://github.com/apache/spark/pull/31412
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org