You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@abrahamfine.com> on 2016/02/09 00:55:44 UTC

Review Request 43348: SQOOP-2828: Sqoop2: AvroIntermediateDataFormat should read Decimals as BigDecimals instead of Strings

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43348/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2828
    https://issues.apache.org/jira/browse/SQOOP-2828


Repository: sqoop-sqoop2


Description
-------

init


Diffs
-----

  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java e409fc1227c639cf8e04b7bf064854e9339bb77c 
  connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java 847572076ee24f35b4c6a270972fdcccbc8ca596 

Diff: https://reviews.apache.org/r/43348/diff/


Testing
-------


Thanks,

Abraham Fine


Re: Review Request 43348: SQOOP-2828: Sqoop2: AvroIntermediateDataFormat should read Decimals as BigDecimals instead of Strings

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43348/#review118749
-----------------------------------------------------------


Ship it!




+1 as long as precommit hook will be happy.

- Jarek Cecho


On Feb. 8, 2016, 11:55 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43348/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 11:55 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2828
>     https://issues.apache.org/jira/browse/SQOOP-2828
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> init
> 
> 
> Diffs
> -----
> 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java e409fc1227c639cf8e04b7bf064854e9339bb77c 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java 847572076ee24f35b4c6a270972fdcccbc8ca596 
> 
> Diff: https://reviews.apache.org/r/43348/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>