You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "Nikita-Shupletsov (via GitHub)" <gi...@apache.org> on 2024/10/18 22:38:51 UTC
[PR] [AMQ-9595] Fix recoverNextMessages when there are messages consumed farther than maxBatchSize. [activemq]
Nikita-Shupletsov opened a new pull request, #1324:
URL: https://github.com/apache/activemq/pull/1324
**What problems does this PR solve?**
Fixes a bug when a durable consumer can received messages which it's already acknowledged
**Why is it beneficial to merge into ActiveMQ?**
It fixes a bug
**How do you make sure this PR is well tested?**
I couldn't find any tests that test that part of code directly. I wrote a high level integration test that covers that edge case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9595] Fix recoverNextMessages when there are messages consumed farther than maxBatchSize. [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1324:
URL: https://github.com/apache/activemq/pull/1324#issuecomment-2423432364
Do you have a unit test the reproduces the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9595] Fix recoverNextMessages when there are messages consumed farther than maxBatchSize. [activemq]
Posted by "Nikita-Shupletsov (via GitHub)" <gi...@apache.org>.
Nikita-Shupletsov commented on PR #1324:
URL: https://github.com/apache/activemq/pull/1324#issuecomment-2423435959
> Do you have a unit test the reproduces the issue?
the test I added reproduces the issue. without the fix the test will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9595] Fix recoverNextMessages when there are messages consumed farther than maxBatchSize. [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1324:
URL: https://github.com/apache/activemq/pull/1324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact