You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by wgtmac <gi...@git.apache.org> on 2018/07/24 20:36:43 UTC
[GitHub] orc pull request #293: ORC-388: Fix isSafeSubtract to use logic operator ins...
GitHub user wgtmac opened a pull request:
https://github.com/apache/orc/pull/293
ORC-388: Fix isSafeSubtract to use logic operator instead of bit operator
Both java and c++ have this issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wgtmac/orc ORC-388
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit 3a52eeff580697db6f8d0624d6e35e4f185979ac
Author: Gang Wu <ga...@...>
Date: 2018-07-24T20:35:19Z
ORC-388: Fix isSafeSubtract to use logic operator instead of bit operator
----
---
[GitHub] orc issue #293: ORC-388: Fix isSafeSubtract to use logic operator instead of...
Posted by wgtmac <gi...@git.apache.org>.
Github user wgtmac commented on the issue:
https://github.com/apache/orc/pull/293
Thanks @majetideepak @xndai for review!
---
[GitHub] orc issue #293: ORC-388: Fix isSafeSubtract to use logic operator instead of...
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/293
+1 LGTM.
logical operator helps in short-circuit evaluation as well.
---
[GitHub] orc issue #293: ORC-388: Fix isSafeSubtract to use logic operator instead of...
Posted by xndai <gi...@git.apache.org>.
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/293
LGTM
---
[GitHub] orc pull request #293: ORC-388: Fix isSafeSubtract to use logic operator ins...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/293
---