[GitHub] [superset] betodealmeida commented on a change in pull request #13288: fix (sqllab): per-tab hide left bar

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #13288:
URL: https://github.com/apache/superset/pull/13288#discussion_r580558923



##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -710,14 +710,17 @@ class SqlEditor extends React.PureComponent {
         ? 'Specify name to CREATE VIEW AS schema in: public'
         : 'Specify name to CREATE TABLE AS schema in: public';
 
+    const leftBarStateClass = this.props.hideLeftBar
+      ? 'schemaPane-exit-done'
+      : 'schemaPane-enter-done';

Review comment:
       Looks like there's a bug in the library: https://github.com/reactjs/react-transition-group/issues/643
   
   Without this, if `this.props.hideLeftBar` was initially set to true the bar wouldn't hide on page load.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org