You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dhalperi <gi...@git.apache.org> on 2016/04/15 02:24:47 UTC

[GitHub] incubator-beam pull request: [BEAM-188] Write: apply GlobalWindows...

GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/181

    [BEAM-188] Write: apply GlobalWindows first

    And do not supply a timestamp when outputting.
    
    Note that this is safe because the functions in the Writer cannot access the window
    or timestamp. When we add per-Window or similar functions to the sinks, we will
    likely do so at a higher level.
    
    Also testing and improving the existing tests. Note that the session test did fail without the accompanying changes to Write.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam write-global-windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #181
    
----
commit 303e14d508a45c848bafb227944e8b8a4078efb0
Author: Dan Halperin <dh...@google.com>
Date:   2016-04-15T00:23:42Z

    [BEAM-188] Write: apply GlobalWindows first
    
    And do not supply a timestamp when outputting.
    
    Note that this is safe because the functions in the Writer cannot access the window
    or timestamp. When we add per-Window or similar functions to the sinks, we will
    likely do so at a higher level.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request: [BEAM-188] Write: apply GlobalWindows...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---