You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2016/02/19 00:08:12 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1168 Switch plugins in...

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/232

    TINKERPOP-1168 Switch plugins in docs preprocessor

    Built the docs, verified that the output is still looking good.
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1168

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #232
    
----
commit bbf5b3f4d61c0aa2266b7430a1e083e8f4c01920
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2016-02-18T22:52:55Z

    splitted implementations.asciidoc into implementations-hadoop.asciidoc and implementations-neo4j.asciidoc

commit e9c6465c9060b2ad4a537bd75ab71c5bae25cf22
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2016-02-18T22:53:44Z

    deactivate Spark plugin for implementations-neo4j.asciidoc and Neo4j plugin for implementations-hadoop.asciidoc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1168 Switch plugins in...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/232#issuecomment-186189165
  
    This fixes the problem but leaves the docs oddly organized.  The `implementations-neo4j.asciidoc` file isn't just "neo4j". It's basically the first half of the "implementations" section which includes "Graph System Provider Requirements" and "TinkerGraph-Gremlin".  
    
    I guess we could fix this as part of:
    
    https://issues.apache.org/jira/browse/TINKERPOP-937
    
    but I think it would be better to just split `implementations-neo4j.asciidoc` into three files on this PR for each of the separate sections.  Either way - your call.
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1168 Switch plugins in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1168 Switch plugins in...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/232#issuecomment-185980647
  
    Epic. Thank you. VOTE +1. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1168 Switch plugins in...

Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/232#issuecomment-186196298
  
    I hope that's just a temporary solution. In an ideal world we would merge those 2 files back together pretty soon (as soon as we bumped out Spark dependency).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---