You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2014/10/01 23:06:02 UTC
Review Request 26246: Remove usage of from
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
Diffs
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
Diff: https://reviews.apache.org/r/26246/diff/
Testing
-------
`make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
Thanks,
Michael Park
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Michael Park <mc...@gmail.com>.
> On Oct. 1, 2014, 9:49 p.m., Cody Maloney wrote:
> > 3rdparty/libprocess/include/process/async.hpp, line 123
> > <https://reviews.apache.org/r/26246/diff/1/?file=710330#file710330line123>
> >
> > Why change the comment style here?
There were 2 versions of a function with this line, except one had a `//` comment and `/* */` comment. It just happened so that the one I kept had the `/* */` comment. Changed to `//` comment.
> On Oct. 1, 2014, 9:49 p.m., Cody Maloney wrote:
> > 3rdparty/libprocess/include/process/async.hpp, line 124
> > <https://reviews.apache.org/r/26246/diff/1/?file=710330#file710330line124>
> >
> > Shouldn't this be a std::forward? (Both here and below in AsyncExecutor::execute).
It was `std::move` because the arguments were being passed by value i.e. `As... as` rather than `As&&... as`. The reason for that was because I was using the `As...` to explicitly instantiate a template. I've changed it to be `As&&...` now and use `std::forward`.
> On Oct. 1, 2014, 9:49 p.m., Cody Maloney wrote:
> > 3rdparty/libprocess/include/process/c++11/defer.hpp, line 254
> > <https://reviews.apache.org/r/26246/diff/1/?file=710331#file710331line254>
> >
> > The joys of not having C++14 :P
Yep...
> On Oct. 1, 2014, 9:49 p.m., Cody Maloney wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp, line 850
> > <https://reviews.apache.org/r/26246/diff/1/?file=710340#file710340line850>
> >
> > Is it possible to do this without having to change naming to disambiguate the overloads?
Reverted to just `run` and `static_cast` to pick the overload.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55138
-----------------------------------------------------------
On Oct. 5, 2014, 5:23 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26246/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 5:23 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
> For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
> I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
> There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
> 3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
> 3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
> 3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
> 3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
> 3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
> 3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
> 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
>
> Diff: https://reviews.apache.org/r/26246/diff/
>
>
> Testing
> -------
>
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55138
-----------------------------------------------------------
3rdparty/libprocess/include/process/async.hpp
<https://reviews.apache.org/r/26246/#comment95515>
Why change the comment style here?
3rdparty/libprocess/include/process/async.hpp
<https://reviews.apache.org/r/26246/#comment95517>
Shouldn't this be a std::forward? (Both here and below in AsyncExecutor::execute).
3rdparty/libprocess/include/process/c++11/defer.hpp
<https://reviews.apache.org/r/26246/#comment95529>
The joys of not having C++14 :P
3rdparty/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/26246/#comment95530>
Is it possible to do this without having to change naming to disambiguate the overloads?
- Cody Maloney
On Oct. 1, 2014, 9:26 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26246/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 9:26 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
> For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
> I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
> There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
> 3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
> 3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
> 3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
> 3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
> 3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
> 3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
> 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
>
> Diff: https://reviews.apache.org/r/26246/diff/
>
>
> Testing
> -------
>
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55464
-----------------------------------------------------------
Bad patch!
Reviews applied: [26246]
Failed command: ./support/mesos-style.py
Error:
Checking 512 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/include/process/async.hpp:49: Lines should be <= 80 characters long [whitespace/line_length] [2]
3rdparty/libprocess/include/process/async.hpp:104: Lines should be <= 80 characters long [whitespace/line_length] [2]
Total errors found: 2
- Mesos ReviewBot
On Oct. 5, 2014, 5:23 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26246/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 5:23 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
> For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
> I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
> There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
> 3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
> 3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
> 3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
> 3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
> 3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
> 3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
> 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
>
> Diff: https://reviews.apache.org/r/26246/diff/
>
>
> Testing
> -------
>
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
-----------------------------------------------------------
(Updated Oct. 5, 2014, 7:35 a.m.)
Review request for mesos and Dominic Hamon.
Changes
-------
GCC-4.8 complains about not having `this->`
Repository: mesos-git
Description
-------
With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
Diffs (updated)
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
3rdparty/libprocess/src/tests/timeseries_tests.cpp fd906b869e8bbf5c07c67c5319dec82681e811b7
Diff: https://reviews.apache.org/r/26246/diff/
Testing
-------
`make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
Thanks,
Michael Park
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
-----------------------------------------------------------
(Updated Oct. 5, 2014, 7:05 a.m.)
Review request for mesos and Dominic Hamon.
Changes
-------
Changes necessary from removing `<stout/list.hpp>`. We should be using `std::vector` anyway.
Repository: mesos-git
Description
-------
With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
Diffs (updated)
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
3rdparty/libprocess/src/tests/timeseries_tests.cpp fd906b869e8bbf5c07c67c5319dec82681e811b7
Diff: https://reviews.apache.org/r/26246/diff/
Testing
-------
`make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
Thanks,
Michael Park
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
-----------------------------------------------------------
(Updated Oct. 5, 2014, 6:11 a.m.)
Review request for mesos and Dominic Hamon.
Changes
-------
Address mesos-style.py
Repository: mesos-git
Description
-------
With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
Diffs (updated)
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
Diff: https://reviews.apache.org/r/26246/diff/
Testing
-------
`make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
Thanks,
Michael Park
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
-----------------------------------------------------------
(Updated Oct. 5, 2014, 6:05 a.m.)
Review request for mesos and Dominic Hamon.
Repository: mesos-git
Description
-------
With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
Diffs
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
Diff: https://reviews.apache.org/r/26246/diff/
Testing
-------
`make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
Thanks,
Michael Park
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
-----------------------------------------------------------
(Updated Oct. 5, 2014, 5:23 a.m.)
Review request for mesos and Dominic Hamon.
Changes
-------
Address comments from dhamon and cmaloney
Repository: mesos-git
Description
-------
With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
Diffs (updated)
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
Diff: https://reviews.apache.org/r/26246/diff/
Testing
-------
`make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
Thanks,
Michael Park
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Michael Park <mc...@gmail.com>.
> On Oct. 1, 2014, 9:26 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/async.hpp, line 123
> > <https://reviews.apache.org/r/26246/diff/1/?file=710330#file710330line123>
> >
> > we prefer // comments
There were 2 versions of a function with this line, except one had a `//` comment and `/* */` comment. It just happened so that the one I kept had the `/* */` comment. Changed to `//` comment.
> On Oct. 1, 2014, 9:26 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/async.hpp, line 204
> > <https://reviews.apache.org/r/26246/diff/1/?file=710330#file710330line204>
> >
> > std::move should be added to configure.ac
I'll work on fixing this in a separate patch.
> On Oct. 1, 2014, 9:26 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/c++11/deferred.hpp, line 278
> > <https://reviews.apache.org/r/26246/diff/1/?file=710332#file710332line278>
> >
> > why did you move these? having friends at the top of private: is expected.
I didn't know, moved back to the top. It's not specified in the style guide, and the Google style guide just says: "Friend declarations should always be in the private section. If copying and assignment are disabled with a macro such as DISALLOW_COPY_AND_ASSIGN, it should be at the end of the private: section, and should be the last thing in the class."
> On Oct. 1, 2014, 9:26 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/c++11/dispatch.hpp, line 265
> > <https://reviews.apache.org/r/26246/diff/1/?file=710334#file710334line265>
> >
> > this comment isn't accurate any more :D
Removed.
> On Oct. 1, 2014, 9:26 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 345
> > <https://reviews.apache.org/r/26246/diff/1/?file=710336#file710336line345>
> >
> > i think you'll need the line length NOLINT here. did you run the checkstyle?
I do indeed need `NOLINT` here. I've added it back to keep consistent with others, but I don't see why we would use it here. Isn't it better to just wrap it properly? I think the only reasonable use case for `NOLINT` was for the preprocessor expansions, since the expanded source code resulted in one long line.
> On Oct. 1, 2014, 9:26 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp, line 850
> > <https://reviews.apache.org/r/26246/diff/1/?file=710340#file710340line850>
> >
> > addAndRun might be more descriptive
Reverted to just `run`.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55133
-----------------------------------------------------------
On Oct. 5, 2014, 5:23 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26246/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 5:23 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
> For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
> I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
> There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
> 3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
> 3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
> 3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
> 3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
> 3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
> 3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
> 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
>
> Diff: https://reviews.apache.org/r/26246/diff/
>
>
> Testing
> -------
>
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Oct. 1, 2014, 2:26 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/async.hpp, line 204
> > <https://reviews.apache.org/r/26246/diff/1/?file=710330#file710330line204>
> >
> > std::move should be added to configure.ac
>
> Michael Park wrote:
> I'll work on fixing this in a separate patch.
please make this patch dependent on it.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55133
-----------------------------------------------------------
On Oct. 5, 2014, 12:35 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26246/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2014, 12:35 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
> For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
> I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
> There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
> 3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
> 3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
> 3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
> 3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
> 3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
> 3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
> 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
> 3rdparty/libprocess/src/tests/timeseries_tests.cpp fd906b869e8bbf5c07c67c5319dec82681e811b7
>
> Diff: https://reviews.apache.org/r/26246/diff/
>
>
> Testing
> -------
>
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55133
-----------------------------------------------------------
3rdparty/libprocess/include/process/async.hpp
<https://reviews.apache.org/r/26246/#comment95504>
we prefer // comments
3rdparty/libprocess/include/process/async.hpp
<https://reviews.apache.org/r/26246/#comment95505>
std::move should be added to configure.ac
3rdparty/libprocess/include/process/c++11/deferred.hpp
<https://reviews.apache.org/r/26246/#comment95512>
why did you move these? having friends at the top of private: is expected.
3rdparty/libprocess/include/process/c++11/dispatch.hpp
<https://reviews.apache.org/r/26246/#comment95513>
this comment isn't accurate any more :D
3rdparty/libprocess/include/process/future.hpp
<https://reviews.apache.org/r/26246/#comment95506>
i think you'll need the line length NOLINT here. did you run the checkstyle?
3rdparty/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/26246/#comment95514>
addAndRun might be more descriptive
- Dominic Hamon
On Oct. 1, 2014, 2:26 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26246/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 2:26 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
> For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
> I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
> There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
> 3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
> 3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
> 3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
> 3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
> 3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
> 3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
> 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
>
> Diff: https://reviews.apache.org/r/26246/diff/
>
>
> Testing
> -------
>
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/#review55151
-----------------------------------------------------------
Bad patch!
Reviews applied: [26246]
Failed command: ./support/mesos-style.py
Error:
Checking 510 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/include/process/future.hpp:325: Lines should very rarely be longer than 100 characters [whitespace/line_length] [4]
3rdparty/libprocess/include/process/c++11/dispatch.hpp:108: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Total errors found: 2
- Mesos ReviewBot
On Oct. 1, 2014, 9:26 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26246/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 9:26 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
> For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
> I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
> There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
> 3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
> 3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
> 3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
> 3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
> 3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
> 3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
> 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
> 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
>
> Diff: https://reviews.apache.org/r/26246/diff/
>
>
> Testing
> -------
>
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 26246: Remove usage of
from libprocess.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26246/
-----------------------------------------------------------
(Updated Oct. 1, 2014, 2:26 p.m.)
Review request for mesos and Dominic Hamon.
Repository: mesos-git
Description
-------
With variadic template support now required in Mesos, the preprocessor expansion technique is no longer necessary.
For `defer.hpp`, `deferred.hpp`, `delay.hpp`, `dispatch.hpp` and `executor.hpp`, there are 2 separate versions.
I've removed the usage of `<stout/preprocessor.hpp>` from the `c++11/` directory but left the pre-c++11 versions alone.
There are implementation details that make the pre-c++11 versions more tricky to fix and I believe it's better to just let them obselete out.
Diffs
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07696748f2e2e20add62ecd554da516ae8f
3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b835bd969d9560f2319e8e9d2b2f14d17b
3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db1df50829a5aad76eb91ea6a86e8969c1d
3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4
3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d29fa6e64f823b0ab40ec51889bf8947f60
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
Diff: https://reviews.apache.org/r/26246/diff/
Testing
-------
`make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
Thanks,
Michael Park