You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Shreepadma Venugopalan <sh...@cloudera.com> on 2014/03/27 00:08:12 UTC
Review Request 19704: SENTRY-138: Use server timestamp for createTime for
role, privilege and group
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19704/
-----------------------------------------------------------
Review request for sentry, Brock Noland and Prasad Mujumdar.
Bugs: SENTRY-138
https://issues.apache.org/jira/browse/SENTRY-138
Repository: sentry
Description
-------
This patch does the following,
1. Sets timestamp on service side in SentryStore.java right before persisting the relevant object.
2. Fixes up the table names, index names in package.jdo, which maps java classes to underlying tables.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 03f7549
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 9c678d5
Diff: https://reviews.apache.org/r/19704/diff/
Testing
-------
All tests pass.
Thanks,
Shreepadma Venugopalan
Re: Review Request 19704: SENTRY-138: Use server timestamp for createTime
for role, privilege and group
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19704/#review38687
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
<https://reviews.apache.org/r/19704/#comment70983>
Should we add a unique index to group name here?
- Brock Noland
On March 26, 2014, 11:08 p.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19704/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 11:08 p.m.)
>
>
> Review request for sentry, Brock Noland and Prasad Mujumdar.
>
>
> Bugs: SENTRY-138
> https://issues.apache.org/jira/browse/SENTRY-138
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This patch does the following,
>
> 1. Sets timestamp on service side in SentryStore.java right before persisting the relevant object.
> 2. Fixes up the table names, index names in package.jdo, which maps java classes to underlying tables.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 03f7549
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 9c678d5
>
> Diff: https://reviews.apache.org/r/19704/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>
Re: Review Request 19704: SENTRY-138: Use server timestamp for createTime
for role, privilege and group
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19704/#review38692
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
<https://reviews.apache.org/r/19704/#comment70990>
Should this also be changed to DB_PRIVILEGE_ID ?
- Prasad Mujumdar
On March 26, 2014, 11:08 p.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19704/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 11:08 p.m.)
>
>
> Review request for sentry, Brock Noland and Prasad Mujumdar.
>
>
> Bugs: SENTRY-138
> https://issues.apache.org/jira/browse/SENTRY-138
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This patch does the following,
>
> 1. Sets timestamp on service side in SentryStore.java right before persisting the relevant object.
> 2. Fixes up the table names, index names in package.jdo, which maps java classes to underlying tables.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 03f7549
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 9c678d5
>
> Diff: https://reviews.apache.org/r/19704/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>
Re: Review Request 19704: SENTRY-138: Use server timestamp for createTime
for role, privilege and group
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19704/#review38782
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
<https://reviews.apache.org/r/19704/#comment71065>
There's already an unique index on groupName. Look at line 36.
- Shreepadma Venugopalan
On March 26, 2014, 11:08 p.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19704/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 11:08 p.m.)
>
>
> Review request for sentry, Brock Noland and Prasad Mujumdar.
>
>
> Bugs: SENTRY-138
> https://issues.apache.org/jira/browse/SENTRY-138
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This patch does the following,
>
> 1. Sets timestamp on service side in SentryStore.java right before persisting the relevant object.
> 2. Fixes up the table names, index names in package.jdo, which maps java classes to underlying tables.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 03f7549
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 9c678d5
>
> Diff: https://reviews.apache.org/r/19704/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>
Re: Review Request 19704: SENTRY-138: Use server timestamp for createTime
for role, privilege and group
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19704/#review39097
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On March 28, 2014, 7:12 p.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19704/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 7:12 p.m.)
>
>
> Review request for sentry, Brock Noland and Prasad Mujumdar.
>
>
> Bugs: SENTRY-138
> https://issues.apache.org/jira/browse/SENTRY-138
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This patch does the following,
>
> 1. Sets timestamp on service side in SentryStore.java right before persisting the relevant object.
> 2. Fixes up the table names, index names in package.jdo, which maps java classes to underlying tables.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 03f7549
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 9c678d5
>
> Diff: https://reviews.apache.org/r/19704/diff/
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>
Re: Review Request 19704: SENTRY-138: Use server timestamp for createTime
for role, privilege and group
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19704/
-----------------------------------------------------------
(Updated March 28, 2014, 7:12 p.m.)
Review request for sentry, Brock Noland and Prasad Mujumdar.
Changes
-------
Feedback from revision # 1.
Bugs: SENTRY-138
https://issues.apache.org/jira/browse/SENTRY-138
Repository: sentry
Description
-------
This patch does the following,
1. Sets timestamp on service side in SentryStore.java right before persisting the relevant object.
2. Fixes up the table names, index names in package.jdo, which maps java classes to underlying tables.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 03f7549
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 9c678d5
Diff: https://reviews.apache.org/r/19704/diff/
Testing
-------
All tests pass.
Thanks,
Shreepadma Venugopalan