You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/21 01:03:12 UTC
[GitHub] [airflow] fritz-astronomer opened a new issue, #26545: Airflow 2.4 Inline Task Logs Should Default to Most Recent Task Try
fritz-astronomer opened a new issue, #26545:
URL: https://github.com/apache/airflow/issues/26545
### Description
I noticed with the new inline task logs view in Airflow 2.4 - the default is to go to the 1st task attempt log, rather than the most recent, which is not the behavior of the prior task logs view.
I think it's a good default to go to the most recent
### Use case/motivation
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tirkarthi commented on issue #26545: Airflow 2.4 Inline Task Logs Should Default to Most Recent Task Try
Posted by GitBox <gi...@apache.org>.
tirkarthi commented on issue #26545:
URL: https://github.com/apache/airflow/issues/26545#issuecomment-1271246523
There were some changes done in below commit where `useState` which always used zero now has a different logic. I have a question where if there are two task instances with 2 and 3 attempts respectively. User selects task-instance-1 and attempt 1 in log UI. Now user navigates to task-instance-2. Should the user have attempt 3 (latest) or attempt 1 (selected in task-instance-1) displayed?
https://github.com/apache/airflow/pull/26556/files#diff-69e2a778c59cc3ec6dbaeb666f063da6a144596d15034db3291bc6066586074eL102
cc: @bbovenzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #26545: Airflow 2.4 Inline Task Logs Should Default to Most Recent Task Try
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #26545:
URL: https://github.com/apache/airflow/issues/26545#issuecomment-1259814924
> I think it's a good default to go to the most recent
oh yeah.
I change this to a bug report because this is not really a feature. This is how logs used to work before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #26545: Airflow 2.4 Inline Task Logs Should Default to Most Recent Task Try
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #26545:
URL: https://github.com/apache/airflow/issues/26545#issuecomment-1271675971
We fixed this issue in: https://github.com/apache/airflow/pull/26556
@tirkarthi We try to maintain the selection manually done by the user. But if a task doesnt have that try number, we will reset to the latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed issue #26545: Airflow 2.4 Inline Task Logs Should Default to Most Recent Task Try
Posted by GitBox <gi...@apache.org>.
bbovenzi closed issue #26545: Airflow 2.4 Inline Task Logs Should Default to Most Recent Task Try
URL: https://github.com/apache/airflow/issues/26545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tirkarthi commented on issue #26545: Airflow 2.4 Inline Task Logs Should Default to Most Recent Task Try
Posted by GitBox <gi...@apache.org>.
tirkarthi commented on issue #26545:
URL: https://github.com/apache/airflow/issues/26545#issuecomment-1271740881
Got it. Thanks @bbovenzi .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org