[jira] [Commented] (OFBIZ-4675) Incorrect fix applied in OFBIZ-4381

["Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199696#comment-13199696 ] 

Jacques Le Roux commented on OFBIZ-4675:
----------------------------------------

You are right Anne, I was too hasty on this, thanks for review. 

I will revert and I guess a better (right?) solution would be to look at createProductStoreWithDefaultSetting method.

Notably this line

<set field="importShippingCtx.filename" value="${sys:getProperty('ofbiz.home')}/applications/commonext/data/ShippingData.xml"/>
                
> Incorrect fix applied in OFBIZ-4381
> -----------------------------------
>
>                 Key: OFBIZ-4675
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4675
>             Project: OFBiz
>          Issue Type: Bug
>          Components: commonext/setup
>    Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Anne Jessel
>            Assignee: Jacques Le Roux
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The fix applied in OFBIZ-4381 was to copy DemoShipping.xml from the ecommerce component (where it is loaded as DEMO data), and add it to commonext component as SEED data.
> IMO this data should not be part of SEED data, as not all users will use this data. Also, the file should not be duplicated.
> I suggest reverting trunk r1167510, R11.04 r1167513, R10.04 r1167514.
> I suspect the correct fix for OFBIZ-4381 is either for the user to load the demo data, or to configure the carriers before trying to create a ProductStore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira