You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <ja...@maven.org> on 2008/06/30 16:07:39 UTC

Re: svn commit: r672727 - /maven/components/trunk/maven-embedder/pom.xml

On 30-Jun-08, at 4:34 AM, brett@apache.org wrote:

> Author: brett
> Date: Mon Jun 30 01:34:38 2008
> New Revision: 672727
>
> URL: http://svn.apache.org/viewvc?rev=672727&view=rev
> Log:
> We require the newer version of the surefire plugin or it is  
> possible to get old versions of plexus-utils in the tests
>

For what do we require a new version of Surefire?

> Modified:
>    maven/components/trunk/maven-embedder/pom.xml
>
> Modified: maven/components/trunk/maven-embedder/pom.xml
> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-embedder/pom.xml?rev=672727&r1=672726&r2=672727&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- maven/components/trunk/maven-embedder/pom.xml (original)
> +++ maven/components/trunk/maven-embedder/pom.xml Mon Jun 30  
> 01:34:38 2008
> @@ -116,11 +116,13 @@
>         <version>2.3</version>
>         <extensions>true</extensions>
>       </plugin>
> +      <!--
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-surefire-plugin</artifactId>
>         <version>2.2</version>
>       </plugin>
> +      -->
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-resources-plugin</artifactId>
>
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
jason at sonatype dot com
----------------------------------------------------------

We all have problems. How we deal with them is a measure of our worth.

  -- Unknown


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r672727 - /maven/components/trunk/maven-embedder/pom.xml

Posted by Brett Porter <br...@apache.org>.
On 01/07/2008, at 12:30 AM, Jason van Zyl wrote:

>
> On 30-Jun-08, at 10:22 AM, Brett Porter wrote:
>
>>
>> On 01/07/2008, at 12:07 AM, Jason van Zyl wrote:
>>
>>>> URL: http://svn.apache.org/viewvc?rev=672727&view=rev
>>>> Log:
>>>> We require the newer version of the surefire plugin or it is  
>>>> possible to get old versions of plexus-utils in the tests
>>>>
>>>
>>> For what do we require a new version of Surefire?
>>
>> I believe using Surefire 2.2, due to its classloading, will pass on  
>> plexus-utils 1.1 to your tests, which is why the embedder tests  
>> failed in that way. Upgrading fixed that test.
>>
>> However (as Henri is finding), some of the embedder tests also want  
>> 2.2 in your local repository which is why this was there in the  
>> first place. We might just need to align the versions to 2.4.2,  
>> though it'd be better if the embedder tests were using test plugins  
>> for constructed repositories, not real ones.
>>
>
> What did you change in the embedder tests the other day?

I added some dependencies to try and populate the local repository  
with the things it expected, since they insist on going to repo1,  
ignoring any settings. This surefire plugin was one of them, and I've  
commented it out for now.

- Brett

>
>
>> - Brett
>>
>>>
>>>
>>>> Modified:
>>>> maven/components/trunk/maven-embedder/pom.xml
>>>>
>>>> Modified: maven/components/trunk/maven-embedder/pom.xml
>>>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-embedder/pom.xml?rev=672727&r1=672726&r2=672727&view=diff
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> ===================================================================
>>>> --- maven/components/trunk/maven-embedder/pom.xml (original)
>>>> +++ maven/components/trunk/maven-embedder/pom.xml Mon Jun 30  
>>>> 01:34:38 2008
>>>> @@ -116,11 +116,13 @@
>>>>      <version>2.3</version>
>>>>      <extensions>true</extensions>
>>>>    </plugin>
>>>> +      <!--
>>>>    <plugin>
>>>>      <groupId>org.apache.maven.plugins</groupId>
>>>>      <artifactId>maven-surefire-plugin</artifactId>
>>>>      <version>2.2</version>
>>>>    </plugin>
>>>> +      -->
>>>>    <plugin>
>>>>      <groupId>org.apache.maven.plugins</groupId>
>>>>      <artifactId>maven-resources-plugin</artifactId>
>>>>
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder,  Apache Maven
>>> jason at sonatype dot com
>>> ----------------------------------------------------------
>>>
>>> We all have problems. How we deal with them is a measure of our  
>>> worth.
>>>
>>> -- Unknown
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> --
>> Brett Porter
>> brett@apache.org
>> http://blogs.exist.com/bporter/
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> jason at sonatype dot com
> ----------------------------------------------------------
>
> What matters is not ideas, but the people who have them. Good people  
> can fix bad ideas, but good ideas can't save bad people.
>
> -- Paul Graham
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r672727 - /maven/components/trunk/maven-embedder/pom.xml

Posted by Jason van Zyl <ja...@maven.org>.
On 30-Jun-08, at 10:22 AM, Brett Porter wrote:

>
> On 01/07/2008, at 12:07 AM, Jason van Zyl wrote:
>
>>> URL: http://svn.apache.org/viewvc?rev=672727&view=rev
>>> Log:
>>> We require the newer version of the surefire plugin or it is  
>>> possible to get old versions of plexus-utils in the tests
>>>
>>
>> For what do we require a new version of Surefire?
>
> I believe using Surefire 2.2, due to its classloading, will pass on  
> plexus-utils 1.1 to your tests, which is why the embedder tests  
> failed in that way. Upgrading fixed that test.
>
> However (as Henri is finding), some of the embedder tests also want  
> 2.2 in your local repository which is why this was there in the  
> first place. We might just need to align the versions to 2.4.2,  
> though it'd be better if the embedder tests were using test plugins  
> for constructed repositories, not real ones.
>

What did you change in the embedder tests the other day?

> - Brett
>
>>
>>
>>> Modified:
>>>  maven/components/trunk/maven-embedder/pom.xml
>>>
>>> Modified: maven/components/trunk/maven-embedder/pom.xml
>>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-embedder/pom.xml?rev=672727&r1=672726&r2=672727&view=diff
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> ====================================================================
>>> --- maven/components/trunk/maven-embedder/pom.xml (original)
>>> +++ maven/components/trunk/maven-embedder/pom.xml Mon Jun 30  
>>> 01:34:38 2008
>>> @@ -116,11 +116,13 @@
>>>       <version>2.3</version>
>>>       <extensions>true</extensions>
>>>     </plugin>
>>> +      <!--
>>>     <plugin>
>>>       <groupId>org.apache.maven.plugins</groupId>
>>>       <artifactId>maven-surefire-plugin</artifactId>
>>>       <version>2.2</version>
>>>     </plugin>
>>> +      -->
>>>     <plugin>
>>>       <groupId>org.apache.maven.plugins</groupId>
>>>       <artifactId>maven-resources-plugin</artifactId>
>>>
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder,  Apache Maven
>> jason at sonatype dot com
>> ----------------------------------------------------------
>>
>> We all have problems. How we deal with them is a measure of our  
>> worth.
>>
>> -- Unknown
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
jason at sonatype dot com
----------------------------------------------------------

What matters is not ideas, but the people who have them. Good people  
can fix bad ideas, but good ideas can't save bad people.

  -- Paul Graham


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r672727 - /maven/components/trunk/maven-embedder/pom.xml

Posted by Brett Porter <br...@apache.org>.
On 01/07/2008, at 12:07 AM, Jason van Zyl wrote:

>> URL: http://svn.apache.org/viewvc?rev=672727&view=rev
>> Log:
>> We require the newer version of the surefire plugin or it is  
>> possible to get old versions of plexus-utils in the tests
>>
>
> For what do we require a new version of Surefire?

I believe using Surefire 2.2, due to its classloading, will pass on  
plexus-utils 1.1 to your tests, which is why the embedder tests failed  
in that way. Upgrading fixed that test.

However (as Henri is finding), some of the embedder tests also want  
2.2 in your local repository which is why this was there in the first  
place. We might just need to align the versions to 2.4.2, though it'd  
be better if the embedder tests were using test plugins for  
constructed repositories, not real ones.

- Brett

>
>
>> Modified:
>>   maven/components/trunk/maven-embedder/pom.xml
>>
>> Modified: maven/components/trunk/maven-embedder/pom.xml
>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-embedder/pom.xml?rev=672727&r1=672726&r2=672727&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- maven/components/trunk/maven-embedder/pom.xml (original)
>> +++ maven/components/trunk/maven-embedder/pom.xml Mon Jun 30  
>> 01:34:38 2008
>> @@ -116,11 +116,13 @@
>>        <version>2.3</version>
>>        <extensions>true</extensions>
>>      </plugin>
>> +      <!--
>>      <plugin>
>>        <groupId>org.apache.maven.plugins</groupId>
>>        <artifactId>maven-surefire-plugin</artifactId>
>>        <version>2.2</version>
>>      </plugin>
>> +      -->
>>      <plugin>
>>        <groupId>org.apache.maven.plugins</groupId>
>>        <artifactId>maven-resources-plugin</artifactId>
>>
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> jason at sonatype dot com
> ----------------------------------------------------------
>
> We all have problems. How we deal with them is a measure of our worth.
>
> -- Unknown
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org