You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by al...@apache.org on 2019/02/20 23:25:51 UTC

[beam] branch master updated: Fix potential memory leak in Lifted Combine.

This is an automated email from the ASF dual-hosted git repository.

altay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new f497c68  Fix potential memory leak in Lifted Combine.
     new 8fafbce  Merge pull request #7913 from lostluck/liftedcache
f497c68 is described below

commit f497c68e211b42c7697f41f8cbd2dd8c575a512c
Author: Robert Burke <ro...@frantil.com>
AuthorDate: Wed Feb 20 23:10:50 2019 +0000

    Fix potential memory leak in Lifted Combine.
---
 sdks/go/pkg/beam/core/runtime/exec/combine.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sdks/go/pkg/beam/core/runtime/exec/combine.go b/sdks/go/pkg/beam/core/runtime/exec/combine.go
index 19fde6f..684ec7f 100644
--- a/sdks/go/pkg/beam/core/runtime/exec/combine.go
+++ b/sdks/go/pkg/beam/core/runtime/exec/combine.go
@@ -339,6 +339,9 @@ func (n *LiftedCombine) FinishBundle(ctx context.Context) error {
 			return err
 		}
 	}
+	// Clear the cache now since all elements have been output.
+	// Down isn't guaranteed to be called.
+	n.cache = nil
 
 	return n.Out.FinishBundle(ctx)
 }