You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/10 09:32:06 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #39482: [SPARK-41877][CONNECT][TESTS] Reenable unpivot test and separate negative test
HyukjinKwon opened a new pull request, #39482:
URL: https://github.com/apache/spark/pull/39482
### What changes were proposed in this pull request?
This PR proposes to reenable unpivot test cases, and separate negative test cases that fail with a different result. I filed a separate JIRA for that.
Additionally, I also added one assert to be same as the regular PySpark side.
### Why are the changes needed?
To make sure on the test coverage, and feature parity.
### Does this PR introduce _any_ user-facing change?
No, test-only. Adds an assert to be consistent with the regular PySpark side.
### How was this patch tested?
Unittests were factored out. CI in this PR should test this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39482: [SPARK-41877][CONNECT][TESTS] Reenable unpivot test and separate negative test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #39482:
URL: https://github.com/apache/spark/pull/39482#discussion_r1065540654
##########
python/pyspark/sql/tests/test_dataframe.py:
##########
@@ -768,6 +750,34 @@ def test_unpivot(self):
df.melt("id", ["int", "double"], "var", "val").collect(),
)
+ def test_unpivot_negative(self):
Review Comment:
```suggestion
def test_unpivot_negative(self):
# SPARK-39877: test the DataFrame.unpivot method
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39482: [SPARK-41877][CONNECT][TESTS] Reenable unpivot test and separate negative test
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39482:
URL: https://github.com/apache/spark/pull/39482#issuecomment-1377386823
merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39482: [SPARK-41877][CONNECT][TESTS] Reenable unpivot test and separate negative test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39482:
URL: https://github.com/apache/spark/pull/39482#issuecomment-1376971090
cc @zhengruifeng FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39482: [SPARK-41877][CONNECT][TESTS] Reenable unpivot test and separate negative test
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39482: [SPARK-41877][CONNECT][TESTS] Reenable unpivot test and separate negative test
URL: https://github.com/apache/spark/pull/39482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org