You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/19 21:02:30 UTC

[GitHub] [hbase] bitoffdev commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

bitoffdev commented on a change in pull request #2282:
URL: https://github.com/apache/hbase/pull/2282#discussion_r473316648



##########
File path: hbase-shell/src/main/ruby/hbase/taskmonitor.rb
##########
@@ -107,88 +107,5 @@ def tasksOnHost(filter, host)
 
       tasks
     end
-
-    #---------------------------------------------------------------------------------------------------
-    # Prints a table of filtered tasks on requested hosts
-    def tasks(filter, hosts)

Review comment:
       The new formatter is in use now and some of this logic moved to Processlist#_processlist_impl. This method is very tailored to printing actual output, which by convention goes in the command file itself. As it is not general purpose, I don't feel that this method is worth keeping around, but I can leave it and mark it as deprecated if you think that would be better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org