[GitHub] [airflow] Lee-W commented on a diff in pull request #34002: test(providers/microsfot): add system test for AzureContainerVolumeHook and AzureContainerRegistryHook

["Lee-W (via GitHub)" <gi...@apache.org>]

Lee-W commented on code in PR #34002:
URL: https://github.com/apache/airflow/pull/34002#discussion_r1314533210


##########
tests/system/providers/microsoft/azure/example_azure_container_instances.py:
##########
@@ -52,7 +55,39 @@
         task_id="start_container",
     )
 
+    t2 = AzureContainerInstancesOperator(
+        ci_conn_id="azure_default",
+        registry_conn_id=None,
+        resource_group="resource-group",
+        name="aci-test-{{ ds }}",
+        image=f"{CONTAINER_REGISTRY_SERVER}:hello-world",
+        region="WestUS2",
+        environment_variables={},
+        volumes=[],
+        memory_in_gb=4.0,
+        cpu=1.0,
+        task_id="start_container_with_custom_container_registry",
+    )
 
+    t3 = AzureContainerInstancesOperator(
+        ci_conn_id="azure_default",
+        registry_conn_id=None,
+        resource_group="resource-group",
+        name="aci-test-{{ ds }}",
+        image="hello-world",
+        region="WestUS2",
+        environment_variables={},
+        volumes=[
+            AzureContainerVolumeHook().get_file_volume(
+                mount_name="mountname",
+                share_name=AZURE_VOLUME_SHARE_NAME,
+                storage_account_name=AZURE_STORAGE_ACOOUNT,
+            )
+        ],

Review Comment:
   Got it. Thanks for helping out. Let me turn this to draft and work on that first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org