You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/19 23:13:19 UTC
[GitHub] [fineract] francisguchie opened a new pull request #1262: FINERACT-1094 squashed commits
francisguchie opened a new pull request #1262:
URL: https://github.com/apache/fineract/pull/1262
https://issues.apache.org/jira/browse/FINERACT-1094
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-677631504
And with this PR: https://github.com/apache/fineract/pull/1263 now merged. Thanks to @ptuomola and @xurror . Anyone can now fork Fineract 1.x and integrate Pentaho into it. I am closing this PR as it contains third party software which has conflicts with the Apache License. Thanks for the work @francisguchie . You are a valuable developer and QA specialist for Fineract and Mifos. Keep up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-701695081
https://issues.apache.org/jira/browse/FINERACT-1127 is picking this up...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] edcable commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
edcable commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-677692998
@xurror Thanks for providing a version of the PR that is Apache-compliant to enable distributions to run on top of Fineract that can run Pentaho.
@awasum Thanks for explaining the situation and context to @francisguchie. I just wanted to clarify on one bit of terminology that you had used around "hard fork" as it usually has a pretty negative connotation and consists of a downstream solution that is divergently forked from the upstream and not in-line with the vision of the upstream codebase.
As you noted in the rest of your comment, the Mifos Initiatives maintains an open source distribution, Mifos X, on top of the upstream release that provides a full solution on top of the Fineract release containing a UI (AngularJS community-app) and reporting (Pentaho).
For now, the Mifos Initiative will continue to maintain support for Pentaho via Mifos X but welcomes community contributions on an Apache Fineract compliant reporting solution.
My suggestion would also be to identify a tool that is Apache-compliant, and works well within the the Fineract-CN architecture and addresses those needs so any investment in development effort for a new reporting tool could be shared across both Fineract and Fineract CN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-677629795
I think another option would be to integrate Fineract with some reporting solution that has an Apache-compatible license (e.g. BIRT I think is with Eclipse license) and port the existing reports from Pentaho. That might be the easiest approach.
Regards
Petri
> On 20 Aug 2020, at 3:19 PM, Awasum Yannick <no...@github.com> wrote:
>
>
> Dear Yemdjih and All, I would like to know and understand the licensing breach. Kindly share a link for me to understand. Are there any other compatible reporting tools we can use other than pentaho? For a system not to have formatted reports, it will lose "steam" , we need a system with reports My Kind Regards Francis Guchie Kirago Skype: francisguchie Whatsapp: 232 79 19 44 07 LINKEDIN: https://www.linkedin.com/in/francis-guchie-kirago-a4379617/ <https://www.linkedin.com/in/francis-guchie-kirago-a4379617/> twitter: @francisguchie <https://github.com/francisguchie>
> … <x-msg://6/#>
> On Thu, Aug 20, 2020 at 3:05 AM Yemdjih Kaze Nasser < @.> wrote: @.*** commented on this pull request. Hello @francisguchie <https://github.com/francisguchie> https://github.com/francisguchie <https://github.com/francisguchie>, unfortunately this PR cannot be merged due to licensing breach. Fineract cannot ship with Pentaho. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1262 (review) <https://github.com/apache/fineract/pull/1262#pullrequestreview-471095762>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFNCABTE2SXOI4NOIK6YGMLSBSHJPANCNFSM4QFOIV4A <https://github.com/notifications/unsubscribe-auth/AFNCABTE2SXOI4NOIK6YGMLSBSHJPANCNFSM4QFOIV4A> .
>
> Pentaho Reports is not allowed in any Apache project and Apache Fineract in particular because its license is a conflict for the Apache License. Read more here on licenses which can be allowed in Apache Software: https://www.apache.org/legal/resolved.html#category-x <https://www.apache.org/legal/resolved.html#category-x>
> Pentaho uses LGPL which is not compatible and legally not allowed in an Apache Licenses Software like Fineract.
>
> What we can do is get Mifos Intiative to run a hard fork of Fineract 1.x which has reports integrated and always pulling from the upstream Fineract 1.x version. That way we have one place for distributing a Fineract backend with pentaho support. Or everyone can run their own custom Fineract 1.x fork with Pentaho integrated.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub <https://github.com/apache/fineract/pull/1262#issuecomment-677626634>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJVCQCSIH42N4R22ENS6DSBUIGHANCNFSM4QFOIV4A>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-677626634
> Dear Yemdjih and All, I would like to know and understand the licensing breach. Kindly share a link for me to understand. Are there any other compatible reporting tools we can use other than pentaho? For a system not to have formatted reports, it will lose "steam" , we need a system with reports My Kind Regards Francis Guchie Kirago *Skype:* francisguchie *Whatsapp: *232 79 19 44 07 *LINKEDIN:* https://www.linkedin.com/in/francis-guchie-kirago-a4379617/ twitter: @francisguchie
> […](#)
> On Thu, Aug 20, 2020 at 3:05 AM Yemdjih Kaze Nasser < ***@***.***> wrote: ***@***.**** commented on this pull request. Hello @francisguchie <https://github.com/francisguchie>, unfortunately this PR cannot be merged due to licensing breach. Fineract cannot ship with Pentaho. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <[#1262 (review)](https://github.com/apache/fineract/pull/1262#pullrequestreview-471095762)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFNCABTE2SXOI4NOIK6YGMLSBSHJPANCNFSM4QFOIV4A> .
Pentaho Reports is not allowed in any Apache project and Apache Fineract in particular because its license is a conflict for the Apache License. Read more here on licenses which can be allowed in Apache Software: https://www.apache.org/legal/resolved.html#category-x
Pentaho uses LGPL which is not compatible and legally not allowed in an Apache Licenses Software like Fineract.
What we can do is get Mifos Intiative to run a hard fork of Fineract 1.x which has reports integrated and always pulling from the upstream Fineract 1.x version. That way we have one place for distributing a Fineract backend with pentaho support. Or everyone can run their own custom Fineract 1.x fork with Pentaho integrated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-677633839
> I think another option would be to integrate Fineract with some reporting solution that has an Apache-compatible license (e.g. BIRT I think is with Eclipse license) and port the existing reports from Pentaho. That might be the easiest approach. Regards Petri
@ptuomola Thats a smart idea. It will be great to create a JIRA issue to track something like that so anyone can pick it up? And maybe advertise the issue on the mailing list where people are talking about Pentaho so someone can jump on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-677504107
Dear Yemdjih and All,
I would like to know and understand the licensing breach. Kindly share a
link for me to understand.
Are there any other compatible reporting tools we can use other than
pentaho?
For a system not to have formatted reports, it will lose "steam" , we need
a system with reports
My Kind Regards
Francis Guchie Kirago
*Skype:* francisguchie
*Whatsapp: *232 79 19 44 07
*LINKEDIN:* https://www.linkedin.com/in/francis-guchie-kirago-a4379617/
twitter: @FrancisGuchie
On Thu, Aug 20, 2020 at 3:05 AM Yemdjih Kaze Nasser <
notifications@github.com> wrote:
> *@xurror* commented on this pull request.
>
> Hello @francisguchie <https://github.com/francisguchie>, unfortunately
> this PR cannot be merged due to licensing breach. Fineract cannot ship with
> Pentaho.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1262#pullrequestreview-471095762>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFNCABTE2SXOI4NOIK6YGMLSBSHJPANCNFSM4QFOIV4A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum closed pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #1262:
URL: https://github.com/apache/fineract/pull/1262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-677845912
https://issues.apache.org/jira/browse/FINERACT-1125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-676913499
On the other hand what can be done is simply handle the problem with classpath duplicates so it can be used without after release by anyone willing to use pentaho
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-677820275
I am very happy for all the contributions -
after reading https://www.apache.org/legal/resolved.html#category-x and https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License
it is clear we can not continue with Pentaho Reports
I voting a +1 for another reporting tool, it was worth the effort to get this through and i have not lost any time. I have learnt alot instead
Thank you all
About this below
_**Thats a smart idea. It will be great to create a JIRA issue to track something like that so anyone can pick it up? And maybe advertise the issue on the mailing list where people are talking about Pentaho so someone can jump on it.**_
I am going to create the issue for it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror edited a comment on pull request #1262: FINERACT-1094 Support for Pentaho Reports
Posted by GitBox <gi...@apache.org>.
xurror edited a comment on pull request #1262:
URL: https://github.com/apache/fineract/pull/1262#issuecomment-676913499
On the other hand what can be done is simply handle the problem with classpath duplicates so it can be used without after release by anyone willing to use pentaho.
Best we can do as of now is this: https://github.com/apache/fineract/pull/1263
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org