You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/23 06:44:23 UTC

[GitHub] [airflow] xinbinhuang opened a new pull request #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces

xinbinhuang opened a new pull request #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces
URL: https://github.com/apache/airflow/pull/7830
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces
URL: https://github.com/apache/airflow/pull/7830#issuecomment-602433319
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=h1) Report
   > Merging [#7830](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cdf1809fce0e59c8379a799f1738d8d813abbf51&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `78.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7830/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7830      +/-   ##
   ==========================================
   - Coverage   86.96%   86.69%   -0.28%     
   ==========================================
     Files         926      927       +1     
     Lines       44917    44953      +36     
   ==========================================
   - Hits        39061    38970      -91     
   - Misses       5856     5983     +127     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/google/cloud/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2JpZ3F1ZXJ5LnB5) | `91.63% <ø> (+0.01%)` | :arrow_up: |
   | [...rflow/providers/google/cloud/operators/mlengine.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9tbGVuZ2luZS5weQ==) | `88.47% <0.00%> (-1.69%)` | :arrow_down: |
   | [...oviders/google/cloud/utils/credentials\_provider.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3V0aWxzL2NyZWRlbnRpYWxzX3Byb3ZpZGVyLnB5) | `93.58% <ø> (ø)` | |
   | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.27% <ø> (ø)` | |
   | [airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==) | `94.11% <94.11%> (ø)` | |
   | [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `87.81% <100.00%> (ø)` | |
   | [airflow/providers/amazon/aws/secrets/ssm.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZWNyZXRzL3NzbS5weQ==) | `100.00% <100.00%> (ø)` | |
   | [.../providers/google/cloud/secrets/secrets\_manager.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3NlY3JldHMvc2VjcmV0c19tYW5hZ2VyLnB5) | `100.00% <100.00%> (ø)` | |
   | [airflow/providers/hashicorp/secrets/vault.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvaGFzaGljb3JwL3NlY3JldHMvdmF1bHQucHk=) | `76.27% <100.00%> (-0.20%)` | :arrow_down: |
   | [airflow/secrets/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL19faW5pdF9fLnB5) | `97.29% <100.00%> (-0.33%)` | :arrow_down: |
   | ... and [56 more](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=footer). Last update [b86bf79...2c9337f](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces
URL: https://github.com/apache/airflow/pull/7830
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces
URL: https://github.com/apache/airflow/pull/7830#issuecomment-602433319
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=h1) Report
   > Merging [#7830](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cdf1809fce0e59c8379a799f1738d8d813abbf51&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `78.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7830/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7830      +/-   ##
   ==========================================
   - Coverage   86.96%   86.69%   -0.28%     
   ==========================================
     Files         926      927       +1     
     Lines       44917    44953      +36     
   ==========================================
   - Hits        39061    38970      -91     
   - Misses       5856     5983     +127     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/google/cloud/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2JpZ3F1ZXJ5LnB5) | `91.63% <ø> (+0.01%)` | :arrow_up: |
   | [...rflow/providers/google/cloud/operators/mlengine.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9tbGVuZ2luZS5weQ==) | `88.47% <0.00%> (-1.69%)` | :arrow_down: |
   | [...oviders/google/cloud/utils/credentials\_provider.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3V0aWxzL2NyZWRlbnRpYWxzX3Byb3ZpZGVyLnB5) | `93.58% <ø> (ø)` | |
   | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.27% <ø> (ø)` | |
   | [airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==) | `94.11% <94.11%> (ø)` | |
   | [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `87.81% <100.00%> (ø)` | |
   | [airflow/providers/amazon/aws/secrets/ssm.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZWNyZXRzL3NzbS5weQ==) | `100.00% <100.00%> (ø)` | |
   | [.../providers/google/cloud/secrets/secrets\_manager.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3NlY3JldHMvc2VjcmV0c19tYW5hZ2VyLnB5) | `100.00% <100.00%> (ø)` | |
   | [airflow/providers/hashicorp/secrets/vault.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvaGFzaGljb3JwL3NlY3JldHMvdmF1bHQucHk=) | `76.27% <100.00%> (-0.20%)` | :arrow_down: |
   | [airflow/secrets/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL19faW5pdF9fLnB5) | `97.29% <100.00%> (-0.33%)` | :arrow_down: |
   | ... and [56 more](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=footer). Last update [b86bf79...2c9337f](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7830: [AIRFLOW-7105] Unify Secrets Backend method interfaces
URL: https://github.com/apache/airflow/pull/7830#issuecomment-602433319
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=h1) Report
   > Merging [#7830](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cdf1809fce0e59c8379a799f1738d8d813abbf51&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `78.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7830/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7830      +/-   ##
   ==========================================
   - Coverage   86.96%   86.69%   -0.28%     
   ==========================================
     Files         926      927       +1     
     Lines       44917    44953      +36     
   ==========================================
   - Hits        39061    38970      -91     
   - Misses       5856     5983     +127     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/google/cloud/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2JpZ3F1ZXJ5LnB5) | `91.63% <ø> (+0.01%)` | :arrow_up: |
   | [...rflow/providers/google/cloud/operators/mlengine.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9tbGVuZ2luZS5weQ==) | `88.47% <0.00%> (-1.69%)` | :arrow_down: |
   | [...oviders/google/cloud/utils/credentials\_provider.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3V0aWxzL2NyZWRlbnRpYWxzX3Byb3ZpZGVyLnB5) | `93.58% <ø> (ø)` | |
   | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.27% <ø> (ø)` | |
   | [airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==) | `94.11% <94.11%> (ø)` | |
   | [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `87.81% <100.00%> (ø)` | |
   | [airflow/providers/amazon/aws/secrets/ssm.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZWNyZXRzL3NzbS5weQ==) | `100.00% <100.00%> (ø)` | |
   | [.../providers/google/cloud/secrets/secrets\_manager.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3NlY3JldHMvc2VjcmV0c19tYW5hZ2VyLnB5) | `100.00% <100.00%> (ø)` | |
   | [airflow/providers/hashicorp/secrets/vault.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvaGFzaGljb3JwL3NlY3JldHMvdmF1bHQucHk=) | `76.27% <100.00%> (-0.20%)` | :arrow_down: |
   | [airflow/secrets/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL19faW5pdF9fLnB5) | `97.29% <100.00%> (-0.33%)` | :arrow_down: |
   | ... and [56 more](https://codecov.io/gh/apache/airflow/pull/7830/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=footer). Last update [b86bf79...2c9337f](https://codecov.io/gh/apache/airflow/pull/7830?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services