[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL
URL: https://github.com/apache/spark/pull/25041#discussion_r300129056
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
 ##########
 @@ -1559,6 +1559,15 @@ object functions {
    */
   def cosh(columnName: String): Column = cosh(Column(columnName))
 
+   /**
+    * @param e hyperbolic angle
+    * @return inverse hyperbolic sine of the given value
+    *
+    * @group math_funcs
+    * @since 3.0.0
+    */
+  def acosh(e: Column): Column = withExpr { Acosh(e.expr) }
 
 Review comment:
   Got it. Thank you for the clean ups.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org