You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by ji...@apache.org on 2004/04/13 02:54:43 UTC

[jira] Created: (AXIS-1304) DefaultEntityResolver is broken

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1304

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1304
    Summary: DefaultEntityResolver is broken
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Axis
 Components: 
             WSDL processing
   Versions:
             current (nightly)

   Assignee: 
   Reporter: Joseph Dane

    Created: Mon, 12 Apr 2004 5:53 PM
    Updated: Mon, 12 Apr 2004 5:53 PM

Description:
in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.

As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.

how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.

Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS-1304) DefaultEntityResolver is broken

Posted by "Dominik Kacprzak (JIRA)" <ax...@ws.apache.org>.
     [ http://nagoya.apache.org/jira/browse/AXIS-1304?page=comments#action_56524 ]
     
Dominik Kacprzak commented on AXIS-1304:
----------------------------------------

Forgot to mention that I successfully run 'all-tests' target with different settings for 'axis.SAXEntityResolverClas' property.

- Dominik

> DefaultEntityResolver is broken
> -------------------------------
>
>          Key: AXIS-1304
>          URL: http://nagoya.apache.org/jira/browse/AXIS-1304
>      Project: Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: current (nightly)
>     Reporter: Joseph Dane
>     Assignee: Davanum Srinivas
>  Attachments: AXIS-1304.tar.gz
>
> in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
> DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.
> As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.
> how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.
> Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS-1304) DefaultEntityResolver is broken

Posted by "Tom Jordahl (JIRA)" <ax...@ws.apache.org>.
     [ http://nagoya.apache.org/jira/browse/AXIS-1304?page=comments#action_56531 ]
     
Tom Jordahl commented on AXIS-1304:
-----------------------------------

Would the component system detailed in http://ws.apache.org/axis/java/integration-guide.html be appropriate for this setting?

> DefaultEntityResolver is broken
> -------------------------------
>
>          Key: AXIS-1304
>          URL: http://nagoya.apache.org/jira/browse/AXIS-1304
>      Project: Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: current (nightly)
>     Reporter: Joseph Dane
>     Assignee: Davanum Srinivas
>  Attachments: AXIS-1304.tar.gz
>
> in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
> DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.
> As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.
> how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.
> Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS-1304) DefaultEntityResolver is broken

Posted by "Dominik Kacprzak (JIRA)" <ax...@ws.apache.org>.
     [ http://nagoya.apache.org/jira/browse/AXIS-1304?page=comments#action_56647 ]
     
Dominik Kacprzak commented on AXIS-1304:
----------------------------------------

As per Dims comment, I will take care of it after we launch Axis 1.2.

- Dominik

> DefaultEntityResolver is broken
> -------------------------------
>
>          Key: AXIS-1304
>          URL: http://nagoya.apache.org/jira/browse/AXIS-1304
>      Project: Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: current (nightly)
>     Reporter: Joseph Dane
>     Assignee: Davanum Srinivas
>  Attachments: AXIS-1304.tar.gz
>
> in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
> DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.
> As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.
> how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.
> Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS-1304) DefaultEntityResolver is broken

Posted by "Dominik Kacprzak (JIRA)" <ax...@ws.apache.org>.
     [ http://nagoya.apache.org/jira/browse/AXIS-1304?page=comments#action_56536 ]
     
Dominik Kacprzak commented on AXIS-1304:
----------------------------------------

I think that treating EntityResolver as a component is a perfectly valid approach.  Would it be okay tho to change API and move DefaultEntityResolver from org.apache.axis.utils to org.apache.axis.components.entityresolver?  What do guys think?

- Dominik

> DefaultEntityResolver is broken
> -------------------------------
>
>          Key: AXIS-1304
>          URL: http://nagoya.apache.org/jira/browse/AXIS-1304
>      Project: Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: current (nightly)
>     Reporter: Joseph Dane
>     Assignee: Davanum Srinivas
>  Attachments: AXIS-1304.tar.gz
>
> in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
> DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.
> As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.
> how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.
> Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS-1304) DefaultEntityResolver is broken

Posted by ji...@apache.org.
The following comment has been added to this issue:

     Author: Joseph Dane
    Created: Tue, 13 Apr 2004 12:24 PM
       Body:
aha.  I suppose it is best to have Axis default to a safe behavior.  Still, wouldn't it
be better to let clients override this by providing their own resolver?  Maybe via
a configuration option?

---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/AXIS-1304?page=comments#action_34998

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1304

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1304
    Summary: DefaultEntityResolver is broken
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Axis
 Components: 
             WSDL processing
   Versions:
             current (nightly)

   Assignee: 
   Reporter: Joseph Dane

    Created: Mon, 12 Apr 2004 5:53 PM
    Updated: Tue, 13 Apr 2004 12:24 PM

Description:
in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.

As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.

how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.

Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (AXIS-1304) DefaultEntityResolver is broken

Posted by "Dominik Kacprzak (JIRA)" <ax...@ws.apache.org>.
     [ http://nagoya.apache.org/jira/browse/AXIS-1304?page=history ]

Dominik Kacprzak updated AXIS-1304:
-----------------------------------

    Attachment: AXIS-1304.tar.gz

Added an axis property (axis.SAXEntityResolverClass) to allow users to specify their own Entity Resolver to be used instead of Axis' DefaultEntityResolver.  If specified class does not exist or does not implement org.xml.sax.EntityResolver interface, Axis will gracefully fall back to the default one.  Also updated DefaultEntityResolver java docs and "Axis Reference Guide" to document the new property.

The attached tar file contains: modified files, a README file, and cvs diff -u output.  NOTE: since I changed files under site and java directories, I run "cvs diff -u" command from a root directory of my ws-axis checkout.

- Dominik

> DefaultEntityResolver is broken
> -------------------------------
>
>          Key: AXIS-1304
>          URL: http://nagoya.apache.org/jira/browse/AXIS-1304
>      Project: Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: current (nightly)
>     Reporter: Joseph Dane
>     Assignee: Davanum Srinivas
>  Attachments: AXIS-1304.tar.gz
>
> in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
> DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.
> As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.
> how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.
> Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (AXIS-1304) DefaultEntityResolver is broken

Posted by ji...@apache.org.
Message:

   The following issue has been re-assigned.

   Assignee: Davanum Srinivas (mailto:dims@yahoo.com)
---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1304

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1304
    Summary: DefaultEntityResolver is broken
       Type: Bug

     Status: Open
   Priority: Major

    Project: Axis
 Components: 
             WSDL processing
   Versions:
             current (nightly)

   Assignee: Davanum Srinivas
   Reporter: Joseph Dane

    Created: Mon, 12 Apr 2004 5:53 PM
    Updated: Sat, 5 Jun 2004 10:56 PM

Description:
in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.

As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.

how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.

Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS-1304) DefaultEntityResolver is broken

Posted by "Davanum Srinivas (JIRA)" <ax...@ws.apache.org>.
     [ http://nagoya.apache.org/jira/browse/AXIS-1304?page=comments#action_56639 ]
     
Davanum Srinivas commented on AXIS-1304:
----------------------------------------

Dominic,

can we please defer this to post 1.2?

thanks,
dims

> DefaultEntityResolver is broken
> -------------------------------
>
>          Key: AXIS-1304
>          URL: http://nagoya.apache.org/jira/browse/AXIS-1304
>      Project: Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: current (nightly)
>     Reporter: Joseph Dane
>     Assignee: Davanum Srinivas
>  Attachments: AXIS-1304.tar.gz
>
> in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
> DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.
> As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.
> how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.
> Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (AXIS-1304) DefaultEntityResolver is broken

Posted by "Dominik Kacprzak (JIRA)" <ax...@ws.apache.org>.
     [ http://nagoya.apache.org/jira/browse/AXIS-1304?page=history ]

Dominik Kacprzak reassigned AXIS-1304:
--------------------------------------

    Assign To: Dominik Kacprzak  (was: Davanum Srinivas)

> DefaultEntityResolver is broken
> -------------------------------
>
>          Key: AXIS-1304
>          URL: http://nagoya.apache.org/jira/browse/AXIS-1304
>      Project: Axis
>         Type: Bug
>   Components: WSDL processing
>     Versions: current (nightly)
>     Reporter: Joseph Dane
>     Assignee: Dominik Kacprzak
>  Attachments: AXIS-1304.tar.gz
>
> in XMLUtils.newDocument(InputSource), the parser has an entity resolver set using
> DefaultEntityResolver.  This resolver just returns an empty input source for all inputs.
> As I read the javadocs for EntityResolver, this is wrong.  The resolver can (should?) also choose to return null, indicating that the parser should open a regular URI connection to the resource.
> how did this come up?  in an attempt to improve on some fairly awful xerces performance, I tried to setup my webapp to use resin's XML/XSL implementation.  As it turns out, resin's XML parser tries to use its EntityResolver to lookup the document itself, which I think is also incorrect.  The DefaultEntityResolver implementation causes this to fail.
> Again, as I read the javadocs, resin should not be doing this, and I'll be reporting a bug there as well.  But ISTM that a DefaultEntityResovler that always returns null makes as much sense as one that always returns an empty stream.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira