You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Doug Cutting <cu...@apache.org> on 2005/10/24 23:35:10 UTC
Welcome Yonik Seeley as committer!
Last week I proposed to the Lucene PMC that we make Yonik Seeley a
committer on Lucene Java. I am pleased to announce that other PMC
members agreed. Welcome, Yonik!
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Welcome Yonik Seeley as committer!
Posted by Yonik Seeley <ys...@gmail.com>.
Thanks everyone, I'm glad to be on board!
-Yonik
On 10/24/05, Doug Cutting <cu...@apache.org> wrote:
>
> Last week I proposed to the Lucene PMC that we make Yonik Seeley a
> committer on Lucene Java. I am pleased to announce that other PMC
> members agreed. Welcome, Yonik!
>
> Doug
>
Re: Welcome Yonik Seeley as committer!
Posted by Doug Cutting <cu...@apache.org>.
Erik Hatcher wrote:
> As for accepting patches - with Lucene I'm personally very conservative
> with applying patches.
There are good reasons to be conservative. When a committer commits a
patch he or she vouches for the quality of that patch. Any problems
that ensue are, to some degree, the responsibility of that committer.
When constructing a patch one should make it easy for a committer to
apply. At a minimum it should apply easily to trunk and pass all unit
tests. It should confine itself to a single issue: changing as little
as possible; adding as little as possible. The case is stronger if
others report to have successfully applied the patch and found it useful.
If one feels a patch is neglected one should be persistent, polite and
patient.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Welcome Yonik Seeley as committer!
Posted by Erik Hatcher <er...@ehatchersolutions.com>.
On 25 Oct 2005, at 02:11, Chris Hostetter wrote:
> 1) Wah-Hoo! Yonik is definitely one of the smartest guys I've
> worked with
> in the past few years.
First, congrats to Yonik and welcome!
> 2) On the subject of commiting and becoming a commiter: I've
> noticed a few
> questions recently about why/when patches can/will-be commited; and
> Yonik's new status has me wondering about how people become
> commiters, and
> what guidelines exist for commiters to know how/when to accept
> patches.
As far as I know there is nothing concrete. Each project governs
things as they desire. When a contributor has posted a critical mass
of high quality patches and keeps active, they are a good candidate
to propose a vote for committership.
As for accepting patches - with Lucene I'm personally very
conservative with applying patches. I prefer to have approval of a
more senior committer - I don't consider myself expert at the lower-
levels of Lucene and do not want to risk any adverse affects.
> This seems like something that would be usefull to toss in the Wiki
> (with
> a pointer from the FAQ).
I'm not sure we can codify the criteria very clearly - it's a very
subjective case-by-case sort of thing.
If you, or someone you respect in the community, desires
committership - the best thing to do is be vocal about it :)
Erik
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Welcome Yonik Seeley as committer!
Posted by Chris Hostetter <ho...@fucit.org>.
: Formally, the process is that someone nominates, and the PMC votes.
: When Lucene was part of Jakarta we used to just have the committers
: vote, since we had little contact with the Jakarta PMC. But now that
: Lucene has its own PMC we can do it the official Apache way.
Ahh, I see ... I didn't realize there was an "official Apache way" but
your comments got me the keywords I needed to find...
http://www.apache.org/foundation/how-it-works.html
As for guidelines for patches, I've tried to consolidate both Erik/Doug's
comments along with my own personal opinions about providing unit tests
into the FAQ...
http://wiki.apache.org/jakarta-lucene/LuceneFAQ#head-bd6009b019133448d3ac22e3989ddf270b845ccb
...if anyone else has any additions or corrections ... it's a wiki.
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Welcome Yonik Seeley as committer!
Posted by Doug Cutting <cu...@apache.org>.
Chris Hostetter wrote:
> 2) On the subject of commiting and becoming a commiter: I've noticed a few
> questions recently about why/when patches can/will-be commited; and
> Yonik's new status has me wondering about how people become commiters, and
> what guidelines exist for commiters to know how/when to accept patches.
Personally, I nominate people to become committers when I see a sequence
of non-trivial, well-constructed patches that may be directly applied to
resolve real issues. Another thing I watch for is are folks who know
their limits. None of us are expert at everything. Thus I appreciate
it when folks show caution in proposing patches, and then respectfully
and patiently listen to other's concerns. We need committers who can
discuss, not argue.
Formally, the process is that someone nominates, and the PMC votes.
When Lucene was part of Jakarta we used to just have the committers
vote, since we had little contact with the Jakarta PMC. But now that
Lucene has its own PMC we can do it the official Apache way.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Welcome Yonik Seeley as committer!
Posted by Chris Hostetter <ho...@fucit.org>.
: Last week I proposed to the Lucene PMC that we make Yonik Seeley a
: committer on Lucene Java. I am pleased to announce that other PMC
: members agreed. Welcome, Yonik!
1) Wah-Hoo! Yonik is definitely one of the smartest guys I've worked with
in the past few years.
2) On the subject of commiting and becoming a commiter: I've noticed a few
questions recently about why/when patches can/will-be commited; and
Yonik's new status has me wondering about how people become commiters, and
what guidelines exist for commiters to know how/when to accept patches.
Is there any documentation on these issues? ... Google searching the mail
archives didn't turn up anything very promising.
This seems like something that would be usefull to toss in the Wiki (with
a pointer from the FAQ).
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org