You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by je...@apache.org on 2015/04/22 12:27:39 UTC
[3/9] allura git commit: [#7836] ticket:739 Add/fix some tests
[#7836] ticket:739 Add/fix some tests
Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/3364dd7c
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/3364dd7c
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/3364dd7c
Branch: refs/heads/ib/7836
Commit: 3364dd7c516ea0589bf021295ee7f6a11a307f55
Parents: 8286322
Author: Igor Bondarenko <je...@gmail.com>
Authored: Thu Mar 5 15:57:23 2015 +0000
Committer: Igor Bondarenko <je...@gmail.com>
Committed: Wed Apr 22 09:44:41 2015 +0000
----------------------------------------------------------------------
ForgeGit/forgegit/tests/functional/test_controllers.py | 8 ++++++++
ForgeGit/forgegit/tests/model/test_repository.py | 11 +++++++++++
ForgeSVN/forgesvn/model/svn.py | 4 ++++
3 files changed, 23 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/allura/blob/3364dd7c/ForgeGit/forgegit/tests/functional/test_controllers.py
----------------------------------------------------------------------
diff --git a/ForgeGit/forgegit/tests/functional/test_controllers.py b/ForgeGit/forgegit/tests/functional/test_controllers.py
index dacec3e..a6995c3 100644
--- a/ForgeGit/forgegit/tests/functional/test_controllers.py
+++ b/ForgeGit/forgegit/tests/functional/test_controllers.py
@@ -683,6 +683,14 @@ class TestFork(_TestCase):
r = self.app.get('/p/test/src-git/merge-requests').follow()
assert '<a href="1/">changed summary</a>' in r
+ @patch.object(GM.Repository, 'merge_base', autospec=True)
+ def test_merge_base_error(self, merge_base):
+ r, mr_num = self._request_merge()
+ merge_base.side_effect = Exception
+ r = self.app.get('/p/test/src-git/merge-requests/%s/' % mr_num)
+ err = r.html.find('div', attrs={'class': 'grid-19 error'})
+ assert_in("Can't find commits to merge", err.getText())
+
class TestDiff(TestController):
http://git-wip-us.apache.org/repos/asf/allura/blob/3364dd7c/ForgeGit/forgegit/tests/model/test_repository.py
----------------------------------------------------------------------
diff --git a/ForgeGit/forgegit/tests/model/test_repository.py b/ForgeGit/forgegit/tests/model/test_repository.py
index dbc12b0..b8506c9 100644
--- a/ForgeGit/forgegit/tests/model/test_repository.py
+++ b/ForgeGit/forgegit/tests/model/test_repository.py
@@ -685,6 +685,17 @@ class TestGitRepo(unittest.TestCase, RepoImplTestBase):
}
assert_equals(diffs, expected)
+ def test_merge_base(self):
+ mr = M.MergeRequest(
+ downstream={
+ 'commit_id': '5c47243c8e424136fd5cdd18cd94d34c66d1955c',
+ },
+ source_branch='zz',
+ target_branch='master',
+ )
+ res = self.repo.merge_base(mr)
+ assert_equal(res, '1e146e67985dcd71c74de79613719bef7bddca4a')
+
class TestGitImplementation(unittest.TestCase):
http://git-wip-us.apache.org/repos/asf/allura/blob/3364dd7c/ForgeSVN/forgesvn/model/svn.py
----------------------------------------------------------------------
diff --git a/ForgeSVN/forgesvn/model/svn.py b/ForgeSVN/forgesvn/model/svn.py
index cd410e3..53b4190 100644
--- a/ForgeSVN/forgesvn/model/svn.py
+++ b/ForgeSVN/forgesvn/model/svn.py
@@ -91,6 +91,10 @@ class Repository(M.Repository):
def rev_to_commit_id(self, rev):
return self._impl.rev_parse(rev)
+ def merge_base(self, mr):
+ rev = self.latest(branch=mr.target_branch)
+ return rev._id if rev else self.head
+
class SVNCalledProcessError(Exception):