You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/12/19 15:04:00 UTC
[jira] [Commented] (SOLR-14042) Fix 7 Varargs methods should only
override or be overridden by other varargs methods warnings
[ https://issues.apache.org/jira/browse/SOLR-14042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000124#comment-17000124 ]
ASF subversion and git services commented on SOLR-14042:
--------------------------------------------------------
Commit 7cfa31b1035fc8cc6f7d66e487e44ede8e4b6414 in lucene-solr's branch refs/heads/master from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7cfa31b ]
SOLR-14042: Fix varargs precommit warnings
> Fix 7 Varargs methods should only override or be overridden by other varargs methods warnings
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-14042
> URL: https://issues.apache.org/jira/browse/SOLR-14042
> Project: Solr
> Issue Type: Sub-task
> Reporter: Andras Salamon
> Assignee: Jason Gerlowski
> Priority: Minor
> Attachments: SOLR-14042-01.patch
>
>
> Precommit lists 7 quite similar varargs related warnings:
> {noformat}
> [ecj-lint] 1. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/ConcatEvaluator.java (at line 46)
> [ecj-lint] public Object doWork(Object values[]) throws IOException {
> [ecj-lint] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike ConcatEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
> --
> [ecj-lint] 2. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DateEvaluator.java (at line 44)
> [ecj-lint] public Object doWork(Object values[]) throws IOException {
> [ecj-lint] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike DateEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
> --
> [ecj-lint] 3. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DbscanEvaluator.java (at line 44)
> [ecj-lint] public Object doWork(Object values[]) throws IOException {
> [ecj-lint] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike DbscanEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
> --
> [ecj-lint] 4. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/EmpiricalDistributionEvaluator.java (at line 41)
> [ecj-lint] public Object doWork(Object[] values) throws IOException {
> [ecj-lint] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike EmpiricalDistributionEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
> --
> [ecj-lint] 5. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/MatchesEvaluator.java (at line 39)
> [ecj-lint] public Object doWork(Object[] values) throws IOException {
> [ecj-lint] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike MatchesEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
> --
> [ecj-lint] 6. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/MatchesEvaluator.java (at line 39)
> [ecj-lint] public Object doWork(Object[] values) throws IOException {
> [ecj-lint] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike MatchesEvaluator.doWork(Object[]) and RecursiveBooleanEvaluator.doWork(Object...)
> --
> [ecj-lint] 7. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/PivotEvaluator.java (at line 45)
> [ecj-lint] public Object doWork(Object[] values) throws IOException {
> [ecj-lint] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike PivotEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...) {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org