[GitHub] [geode] agingade commented on a change in pull request #5623: GEODE-8607: Adding some test API to get oldest tombstone

[GitBox <gi...@apache.org>]

agingade commented on a change in pull request #5623:
URL: https://github.com/apache/geode/pull/5623#discussion_r504938535



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
##########
@@ -450,6 +450,11 @@ boolean testHook_forceExpiredTombstoneGC(int count, long timeout, TimeUnit unit)
 
     @Override
     protected void beforeSleepChecks() {}
+
+    @Override
+    public long getOldestTombstoneTimeDelta() {
+      return tombstones.peek().getVersionTimeStamp() - cacheTime.cacheTimeMillis();

Review comment:
       The peek could return null...
   Will it be a good enough to return version timestamp instead of delta...The caller can calculate delta with different time mechanism (using cacheTime or currentTime).
   
   Also, will it be helpful if the tombstone.toString() info is returned...It has all the information associated with tombstone.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org