You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "linrrzqqq (via GitHub)" <gi...@apache.org> on 2025/10/29 02:58:04 UTC
[PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
linrrzqqq opened a new pull request, #57437:
URL: https://github.com/apache/doris/pull/57437
### What problem does this PR solve?
Issue Number: #48203
Related PR: #xxx
Problem Summary:
### Release note
behavior same with [INSERT](https://dev.mysql.com/doc/refman/8.4/en/string-functions.html#function_insert) function in MySQL.
```text
mysql> SELECT INSERT('hello', 2, 3, '!world!');
+----------------------------------+
| INSERT('hello', 2, 3, '!world!') |
+----------------------------------+
| h!world!o |
+----------------------------------+
mysql> SELECT INSERT('🎉🎊🎈', 2, 1, '🎁');
+--------------------------------------+
| INSERT('🎉🎊🎈', 2, 1, '🎁') |
+--------------------------------------+
| 🎉🎁🎈 |
+--------------------------------------+
```
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [x] Yes. https://github.com/apache/doris-website/pull/3018
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3459429273
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3459883102
# BE UT Coverage Report
Increment line coverage `100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/16dac88db8afe3e2af6c2648141ab216688ee0dd_16dac88db8afe3e2af6c2648141ab216688ee0dd/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/16dac88db8afe3e2af6c2648141ab216688ee0dd_16dac88db8afe3e2af6c2648141ab216688ee0dd/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.75% (18057/34231) |
| Line Coverage | 37.98% (163699/431026) |
| Region Coverage | 32.36% (124791/385642) |
| Branch Coverage | 33.73% (54559/161771) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3459427171
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3460525133
<details>
<summary>ClickBench: <b>Total hot run time: 27.77 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f5b77d9d359cd7dee373405c5fc01847345b3072, data reload: false
query1 0.05 0.05 0.05
query2 0.10 0.05 0.05
query3 0.26 0.09 0.08
query4 1.61 0.12 0.12
query5 0.29 0.26 0.25
query6 1.16 0.64 0.65
query7 0.04 0.03 0.03
query8 0.05 0.04 0.06
query9 0.64 0.53 0.52
query10 0.59 0.58 0.58
query11 0.17 0.12 0.12
query12 0.16 0.12 0.12
query13 0.65 0.61 0.60
query14 1.01 1.03 1.02
query15 0.85 0.84 0.84
query16 0.40 0.41 0.40
query17 1.07 1.06 1.05
query18 0.23 0.21 0.20
query19 1.93 1.80 1.83
query20 0.01 0.01 0.01
query21 15.45 0.19 0.13
query22 5.12 0.06 0.05
query23 15.64 0.26 0.10
query24 2.56 0.54 0.37
query25 0.08 0.06 0.06
query26 0.14 0.14 0.14
query27 0.08 0.05 0.06
query28 4.08 1.14 0.94
query29 12.58 4.00 3.36
query30 0.28 0.13 0.12
query31 2.82 0.62 0.39
query32 3.24 0.55 0.48
query33 3.04 3.05 3.04
query34 15.79 5.14 4.58
query35 4.61 4.59 4.58
query36 0.71 0.51 0.49
query37 0.11 0.07 0.07
query38 0.06 0.04 0.04
query39 0.04 0.02 0.03
query40 0.18 0.17 0.14
query41 0.10 0.04 0.04
query42 0.04 0.03 0.04
query43 0.05 0.04 0.03
Total cold run time: 98.07 s
Total hot run time: 27.77 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #57437:
URL: https://github.com/apache/doris/pull/57437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3459482502
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3460644427
# FE UT Coverage Report
Increment line coverage ` 100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57437_f5b77d9d359cd7dee373405c5fc01847345b3072/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57437_f5b77d9d359cd7dee373405c5fc01847345b3072/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3460928239
# BE UT Coverage Report
Increment line coverage `100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/f5b77d9d359cd7dee373405c5fc01847345b3072_f5b77d9d359cd7dee373405c5fc01847345b3072/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/f5b77d9d359cd7dee373405c5fc01847345b3072_f5b77d9d359cd7dee373405c5fc01847345b3072/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.76% (18065/34243) |
| Line Coverage | 37.99% (163815/431225) |
| Region Coverage | 32.35% (124811/385848) |
| Branch Coverage | 33.72% (54603/161929) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3460508051
<details>
<summary>TPC-DS: <b>Total hot run time: 190584 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f5b77d9d359cd7dee373405c5fc01847345b3072, data reload: false
query1 1085 413 403 403
query2 6570 1732 1697 1697
query3 6767 235 224 224
query4 27077 23893 23203 23203
query5 5157 644 495 495
query6 361 270 245 245
query7 4667 519 314 314
query8 326 293 286 286
query9 8762 2628 2623 2623
query10 567 358 304 304
query11 15419 15258 14914 14914
query12 207 126 119 119
query13 1707 591 461 461
query14 11764 9475 9540 9475
query15 256 205 180 180
query16 7807 686 482 482
query17 1636 829 698 698
query18 2173 478 356 356
query19 318 221 205 205
query20 141 143 133 133
query21 385 140 136 136
query22 4503 4791 4481 4481
query23 35115 34234 33675 33675
query24 8457 2529 2589 2529
query25 607 553 504 504
query26 811 291 172 172
query27 2798 520 403 403
query28 4374 2238 2232 2232
query29 771 671 506 506
query30 317 251 220 220
query31 930 908 788 788
query32 87 74 72 72
query33 613 429 351 351
query34 837 889 604 604
query35 888 912 825 825
query36 1027 1054 946 946
query37 134 126 88 88
query38 3587 3612 3495 3495
query39 1484 1429 1425 1425
query40 223 129 125 125
query41 66 60 63 60
query42 120 114 116 114
query43 506 509 478 478
query44 1272 751 742 742
query45 189 182 172 172
query46 894 1003 654 654
query47 1733 1783 1739 1739
query48 413 435 324 324
query49 710 539 425 425
query50 688 710 424 424
query51 3909 3909 3824 3824
query52 114 116 107 107
query53 255 278 198 198
query54 614 616 551 551
query55 86 95 90 90
query56 330 344 323 323
query57 1165 1192 1123 1123
query58 301 298 290 290
query59 2636 2648 2495 2495
query60 381 369 361 361
query61 175 165 160 160
query62 808 747 687 687
query63 238 201 211 201
query64 3632 1178 876 876
query65 4057 3981 3977 3977
query66 902 432 339 339
query67 15368 15146 14862 14862
query68 8822 912 596 596
query69 511 334 297 297
query70 1335 1274 1296 1274
query71 482 355 324 324
query72 5527 4911 4700 4700
query73 713 591 361 361
query74 9189 9218 8751 8751
query75 4319 3352 2868 2868
query76 3733 1174 762 762
query77 865 431 316 316
query78 9542 9765 9035 9035
query79 1692 811 606 606
query80 696 595 533 533
query81 492 266 235 235
query82 369 165 136 136
query83 299 273 275 273
query84 304 117 97 97
query85 905 485 441 441
query86 341 321 318 318
query87 3750 3725 3671 3671
query88 2873 2299 2279 2279
query89 412 333 307 307
query90 2089 232 228 228
query91 175 172 138 138
query92 89 72 67 67
query93 1147 984 648 648
query94 701 452 351 351
query95 411 341 327 327
query96 493 602 282 282
query97 2963 2973 2883 2883
query98 245 225 219 219
query99 1460 1393 1271 1271
Total cold run time: 279221 ms
Total hot run time: 190584 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3461742454
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3459504461
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3459482449
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3461047117
# FE Regression Coverage Report
Increment line coverage ` 100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57437_f5b77d9d359cd7dee373405c5fc01847345b3072_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57437_f5b77d9d359cd7dee373405c5fc01847345b3072_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3460985101
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (1/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57437_f5b77d9d359cd7dee373405c5fc01847345b3072_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57437_f5b77d9d359cd7dee373405c5fc01847345b3072_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.38% (23946/33548) |
| Line Coverage | 57.79% (249092/431037) |
| Region Coverage | 52.92% (206695/390610) |
| Branch Coverage | 54.64% (88909/162712) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](function) Support alias INSERT for OVERLAY [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57437:
URL: https://github.com/apache/doris/pull/57437#issuecomment-3460360418
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org