You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Phil Steitz (Updated) (JIRA)" <ji...@apache.org> on 2011/12/21 19:23:30 UTC

[jira] [Updated] (DBCP-364) BasicDataSourceFactory#createDataSource return signature should be BasicDataSourceFactory so that caller can invoke methods not declared in DataSource (e.g., close())

     [ https://issues.apache.org/jira/browse/DBCP-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated DBCP-364:
-----------------------------

    Fix Version/s: 2.0
    
> BasicDataSourceFactory#createDataSource return signature should be BasicDataSourceFactory so that caller can invoke methods not declared in DataSource (e.g., close())
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DBCP-364
>                 URL: https://issues.apache.org/jira/browse/DBCP-364
>             Project: Commons Dbcp
>          Issue Type: Improvement
>            Reporter: ori
>            Priority: Trivial
>             Fix For: 2.0
>
>
> BasicDataSourceFactory#createDataSource currently returns a DataSource instance.
> It should a return type of BasicDataSourceFactory. Otherwise the caller has to cast it to invoke close (and other methods specific to the implementation).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira