You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Niklas Fallik (JIRA)" <ji...@apache.org> on 2018/08/10 09:26:00 UTC
[jira] [Updated] (OFBIZ-10512) Change order of parameters in
runSyncIgnore
[ https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Fallik updated OFBIZ-10512:
----------------------------------
Description:
It is confusing that the order of the arguments passed to {{LocalDispatcher.runSyncIgnore()}} is not the same in all overloaded methods.
cf.
{{void runSyncIgnore(String serviceName, Map<String, ? extends Object> context, int transactionTimeout, boolean requireNewTransaction) throws ServiceAuthException, ServiceValidationException, GenericServiceException;
void runSyncIgnore(String serviceName, int transactionTimeout, boolean requireNewTransaction, Object... context) throws ServiceAuthException, ServiceValidationException, GenericServiceException;
(ll. 101 + 102 in LocalDispatcher.java)}}
The {{context}} parameter could be passed as second or as fourth argument, no matter if it is a Map or an Object.
was:
It is confusing that the order of the arguments passed to `LocalDispatcher.runSyncIgnore()` is not the same in all overloaded methods.
cf.
```
void runSyncIgnore(String serviceName, Map<String, ? extends Object> context, int transactionTimeout, boolean requireNewTransaction) throws ServiceAuthException, ServiceValidationException, GenericServiceException;
void runSyncIgnore(String serviceName, int transactionTimeout, boolean requireNewTransaction, Object... context) throws ServiceAuthException, ServiceValidationException, GenericServiceException;```
(ll. 101 + 102 in LocalDispatcher.java)
The `context` parameter could be passed as second or as fourth argument, no matter if it is a Map or an Object.
> Change order of parameters in runSyncIgnore
> -------------------------------------------
>
> Key: OFBIZ-10512
> URL: https://issues.apache.org/jira/browse/OFBIZ-10512
> Project: OFBiz
> Issue Type: Wish
> Reporter: Niklas Fallik
> Priority: Major
>
> It is confusing that the order of the arguments passed to {{LocalDispatcher.runSyncIgnore()}} is not the same in all overloaded methods.
> cf.
> {{void runSyncIgnore(String serviceName, Map<String, ? extends Object> context, int transactionTimeout, boolean requireNewTransaction) throws ServiceAuthException, ServiceValidationException, GenericServiceException;
> void runSyncIgnore(String serviceName, int transactionTimeout, boolean requireNewTransaction, Object... context) throws ServiceAuthException, ServiceValidationException, GenericServiceException;
> (ll. 101 + 102 in LocalDispatcher.java)}}
> The {{context}} parameter could be passed as second or as fourth argument, no matter if it is a Map or an Object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)