You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/04/26 12:17:24 UTC
[GitHub] [druid] liran-funaro opened a new pull request #11160: Remove IncrementalIndex template modifier
liran-funaro opened a new pull request #11160:
URL: https://github.com/apache/druid/pull/11160
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
This patch removes the template modifier from `IncrementalIndex<AggregatorType>` . It is no longer required:
* `private final AggregatorType[] aggs` moved to `OffheapIncrementalIndex` (it is only used there).
* `iterableWithPostAggregations()` defined as `abstract` and implemented in `OnheapIncrementalIndex`/`OffheapIncrementalIndex`.
* `initAggs()` returns `void`.
## Rationale
It is not required. Especially since `OffheapIncrementalIndex` will be removed by: #11124
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #11160: Remove IncrementalIndex template modifier
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #11160:
URL: https://github.com/apache/druid/pull/11160#discussion_r737808438
##########
File path: processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -369,6 +367,61 @@ public boolean isNull(int rowOffset, int aggOffset)
return concurrentGet(rowOffset)[aggOffset].isNull();
}
+ @Override
+ public Iterable<Row> iterableWithPostAggregations(
Review comment:
I see. Thank you for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] liran-funaro commented on a change in pull request #11160: Remove IncrementalIndex template modifier
Posted by GitBox <gi...@apache.org>.
liran-funaro commented on a change in pull request #11160:
URL: https://github.com/apache/druid/pull/11160#discussion_r736285060
##########
File path: processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -369,6 +367,61 @@ public boolean isNull(int rowOffset, int aggOffset)
return concurrentGet(rowOffset)[aggOffset].isNull();
}
+ @Override
+ public Iterable<Row> iterableWithPostAggregations(
Review comment:
When this method was in the generic `IncrementalIndex`, it has to use the generic `AggregatorType` by calling the following abstract generic functions:
```java
AggregatorType[] getAggsForRow(int rowOffset);
Object getAggVal(AggregatorType agg, int rowOffset, int aggPosition);
```
These functions were forced and didn't really fit each of the implementations.
`getAggsForRow()` didn't fit `OffheapIncrementalIndex` since it only have one aggregator instance (not one for each row).
`getAggVal()` didn't fit `OnheapIncrementalIndex` since `rowOffset` and `aggPosition` is only relevant to `BufferAggregator`.
That said, other than that, the implementation is identical in both incremental-index implementations.
It might be possible to find a more generic implementation. But since we are removing `OffheapIncrementalIndex`, I don't see the point of making this effort here.
Once this PR and PR #11124 will be merged, I will try to generify this function for both `OnheapIncrementalIndex` and `OakIncrementalIndex` (#10001).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #11160: Remove IncrementalIndex template modifier
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #11160:
URL: https://github.com/apache/druid/pull/11160#discussion_r736035641
##########
File path: processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -369,6 +367,61 @@ public boolean isNull(int rowOffset, int aggOffset)
return concurrentGet(rowOffset)[aggOffset].isNull();
}
+ @Override
+ public Iterable<Row> iterableWithPostAggregations(
Review comment:
Can you explain the reason for moving this method from `IncrementalInde` to here and `OffheapIncrementalIndex`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] liran-funaro commented on a change in pull request #11160: Remove IncrementalIndex template modifier
Posted by GitBox <gi...@apache.org>.
liran-funaro commented on a change in pull request #11160:
URL: https://github.com/apache/druid/pull/11160#discussion_r736285060
##########
File path: processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -369,6 +367,61 @@ public boolean isNull(int rowOffset, int aggOffset)
return concurrentGet(rowOffset)[aggOffset].isNull();
}
+ @Override
+ public Iterable<Row> iterableWithPostAggregations(
Review comment:
When this method was in the generic `IncrementalIndex`, it has to use the generic `AggregatorType` by calling the following abstract generic functions:
```java
AggregatorType[] getAggsForRow(int rowOffset);
Object getAggVal(AggregatorType agg, int rowOffset, int aggPosition);
```
These functions were forced and didn't really fit each of the implementations.
`getAggsForRow()` didn't fit `OffheapIncrementalIndex` since it only have one aggregator instance (not one for each row).
`getAggVal()` didn't fit `OnheapIncrementalIndex` since `rowOffset` and `aggPosition` is only relevant to `BufferAggregator`.
That said, other than that, the implementation is identical in both incremental-index implementations.
It might be possible to find a more generic implementation. But since we are removing `OffheapIncrementalIndex`, I don't see the point of making this effort here.
Once this PR and PR#1124 will be merged, I will try to generify this function for both `OnheapIncrementalIndex` and `OakIncrementalIndex`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #11160: Remove IncrementalIndex template modifier
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #11160:
URL: https://github.com/apache/druid/pull/11160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] liran-funaro commented on a change in pull request #11160: Remove IncrementalIndex template modifier
Posted by GitBox <gi...@apache.org>.
liran-funaro commented on a change in pull request #11160:
URL: https://github.com/apache/druid/pull/11160#discussion_r736285060
##########
File path: processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java
##########
@@ -369,6 +367,61 @@ public boolean isNull(int rowOffset, int aggOffset)
return concurrentGet(rowOffset)[aggOffset].isNull();
}
+ @Override
+ public Iterable<Row> iterableWithPostAggregations(
Review comment:
When this method was in the generic `IncrementalIndex`, it has to use the generic `AggregatorType` by calling the following abstract generic functions:
```java
AggregatorType[] getAggsForRow(int rowOffset);
Object getAggVal(AggregatorType agg, int rowOffset, int aggPosition);
```
These functions were forced and didn't really fit each of the implementations.
`getAggsForRow()` didn't fit `OffheapIncrementalIndex` since it only have one aggregator instance (not one for each row).
`getAggVal()` didn't fit `OnheapIncrementalIndex` since `rowOffset` and `aggPosition` is only relevant to `BufferAggregator`.
That said, other than that, the implementation is identical in both incremental-index implementations.
It might be possible to find a more generic implementation. But since we are removing `OffheapIncrementalIndex`, I don't see the point of making this effort here.
Once this PR and PR#1124 will be merged, I will try to generify this function for both `OnheapIncrementalIndex` and `OakIncrementalIndex` (#10001).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] liran-funaro commented on pull request #11160: Remove IncrementalIndex template modifier
Posted by GitBox <gi...@apache.org>.
liran-funaro commented on pull request #11160:
URL: https://github.com/apache/druid/pull/11160#issuecomment-952049701
@jihoonson I updated this PR after the merger of #11124.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org